← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 04/11] Avoid cast from const_iterator to iterator

 

Committed in 6493. Thank yuo.

On Sat, Jan 16, 2016 at 04:41:51AM +0100, Simon Richter wrote:
> 
> The standard library requires iterators passed to functions that modify the
> container to be mutable iterators, but GCC's implementation accepts
> const_iterator in some places where these are only used to mark a place,
> but the actual modification happens through a different parameter.
> 
> As this breaks implementations that use the passed iterator to modify the
> container (e.g. because they use a different data organization), this is
> not portable; because we already have a non-const reference to the
> container anyway, this is trivially fixed as well.
> ---
>  common/view/view.cpp          |  2 +-
>  pcbnew/kicad_plugin.cpp       |  2 +-
>  pcbnew/tools/drawing_tool.cpp | 10 +++++-----
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 


References