kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #22733
Re: Final? version of hotkeys patch
Eh, as well...
I forgot that I have the official 4.0.1-stable installed on Arch Linux,
which also has the "Alt-* duplicate hotkeys are possible" bug.
So, I bet it's an ooold thing.
Regards,
Clemens
On 2016-01-18 01:01, Chris Pavlina wrote:
> Eh, don't worry about bisecting or anything, I can take care of this.
> The hotkey stuff hasn't been touched in quite a long time - I'll just
> grab a build from before I started, see if it still does it, and if so
> just go right into the code and fix it.. if it's an old bug it'll be an
> oooold one, maybe since that bit was added.
>
> If it *is* my fault, I don't want anyone spending a long time trying to
> find it for me :)
>
> On Mon, Jan 18, 2016 at 01:01:51AM +0100, Clemens Koller wrote:
>> Hi, Chris!
>>
>> On 2016-01-18 00:47, Chris Pavlina wrote:
>>> Thanks.
>>>
>>> Don't remember if I said this, but Ctrl-Tab being picked up as Ctrl-I is
>>> an old issue - I do actually plan to fix this, though.
>>
>> Nevermind. Ideally, Kicad should let the user know what keys
>> are not supported to avoid user complaints like mine. ;-)
>>
>>> As for duplicate hotkeys not being recognized - do you still have an old
>>> build kicking around to test for me if this is a regression or not? I
>>> *think* it should behave the same there as it did before, as in the end
>>> the duplicate-check ended up being mostly the same code. I don't have a
>>> chance to dig into it right now, but I'll get to it soon.
>>
>> The Alt-* behaviour is propably not a late regression. I guess it's
>> there for a week+ at least. I didn't notice it propably because I was
>> primarily testing with Ctrl-* hotkeys.
>> I just happened to use the Alt-* more than once by accident, last week.
>>
>> My build is current.
>> Pulled late this evening, rebased, rebuilt everything.
>> Executables are <2h old.
>>
>> Let me know if I should git-bisect this thing to find out
>> since when we ride the Alt-* bug.
>>
>> Regards,
>>
>> Clemens
References
-
Re: Final? version of hotkeys patch
From: Chris Pavlina, 2016-01-11
-
Re: Final? version of hotkeys patch
From: Wayne Stambaugh, 2016-01-11
-
Re: Final? version of hotkeys patch
From: Chris Pavlina, 2016-01-11
-
Re: Final? version of hotkeys patch
From: Wayne Stambaugh, 2016-01-11
-
Re: Final? version of hotkeys patch
From: Chris Pavlina, 2016-01-12
-
Re: Final? version of hotkeys patch
From: Chris Pavlina, 2016-01-14
-
Re: Final? version of hotkeys patch
From: Chris Pavlina, 2016-01-16
-
Re: Final? version of hotkeys patch
From: Clemens Koller, 2016-01-17
-
Re: Final? version of hotkeys patch
From: Chris Pavlina, 2016-01-17
-
Re: Final? version of hotkeys patch
From: Clemens Koller, 2016-01-18
-
Re: Final? version of hotkeys patch
From: Chris Pavlina, 2016-01-18