kicad-developers team mailing list archive

[Jon Neal <reportingsjr@xxxxxxxxx>]

Also tested on 64-bit linux. Works fine here.

Jon

On Tue, Jan 19, 2016 at 12:35 PM Chris Pavlina <pavlina.chris@xxxxxxxxx>
wrote:

> Updated patch attached, tested on Linux 64 and Windows 64, works fine.
>
> On Tue, Jan 19, 2016 at 11:06:18AM -0500, Chris Pavlina wrote:
> > I made a few silly mistakes in the patch, I'm testing an updated one on
> multiple platforms currently.
> >
> > 1. I switched to uint32_t as well. uint64_t shouldn't be a _problem_,
> >    I've just been yelled at for wasting precious, precious memory ;)
> >
> > 2. The real problem is that I used cstdint, which I forgot is a C++11
> >    thing. Fixed to use boost/cstdint.hpp, which is available on all
> >    C++ versions. (Note: don't use stdint.h from C, that's not going to
> >    work properly on all platforms even if it does work on most.)
> >
> > 3. Couple more tidy-ups of things I made a bit more complex than they
> >    should be.
> >
> > I'm testing on Linux 64-bit and Windows 64-bit, that's all that's
> > available to me.
> >
> >
> > On Tue, Jan 19, 2016 at 05:03:34PM +0100, jp charras wrote:
> > > Le 19/01/2016 15:02, Chris Pavlina a écrit :
> > > > Just ignore this patch.
> > > > On Jan 14, 2016 18:56, "Chris Pavlina" <pavlina.chris@xxxxxxxxx>
> wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> We have a few minor typing issues with the GR_KB_* constants in
> > > >> include/common.h:
> > > >>
> > > >> - Type is a signed int32 on most platforms, yet we use 0x80000000
> > > >>   (greater than INT_MAX) as a constant.
> > > >>
> > > >>   This has caused people some trouble before:
> > > >>   https://bugs.launchpad.net/kicad/+bug/1445606
> > >
> > > << .. >>
> > >
> > > Using am uint32 for typedef EDA_KEY works for me, and should fix the
> > > issue 1445606
> > >
> > >
> > > --
> > > Jean-Pierre CHARRAS
> > >
> > > _______________________________________________
> > > Mailing list: https://launchpad.net/~kicad-developers
> > > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > > Unsubscribe : https://launchpad.net/~kicad-developers
> > > More help   : https://help.launchpad.net/ListHelp
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>