← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix typing problems with GR_KB_* constants

 

Thanks. Yeah, if the keys actually /behave/ differently now, something 
truly weird is going on - this shouldn't come anywhere near changing 
behavior other than breaking it entirely if I really screwed up ;)

On Tue, Jan 19, 2016 at 10:03:30PM +0100, Bernhard Stegmaier wrote:
> OK, looks like nothing to fix wrt to Ctrl/Cmd.
> 
> From the documentation:
> wxMOD_CONTROL 	
> Ctlr Key, corresponds to Command key on OS X.
> 
> bool 	ControlDown <http://docs.wxwidgets.org/trunk/classwx_keyboard_state.html#ae25436ceab56c88411dac479106b18dd> () const
>  	Returns true if the Control key or Apple/Command key under OS X is pressed.
> 
> Weird that it doesn’t react on the Ctrl key although it exists.
> 
> 
> Regards,
> Bernhard
> 
> 
> > On 19.01.2016, at 21:57, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx> wrote:
> > 
> > I should start to read the documentation… always learning new features here… :)
> > 
> > Seems to work for me on OSX.
> > 
> > One small thing:
> > Ctrl and Cmd seem to be swapped.
> > Ctrl+Left just brings up the context menu, like Ctrl+Shift+Left.
> > Cmd+Left and Cmd+Shift+Left do delete/drag blcok as intended.
> > I checked on my normal version and it is the same there, so no regression.
> > I’ll put it on my todo list if nobody else has an idea how to fix this - not in the near future, before that I will take care of some other things.
> > 
> > 
> > Regards,
> > Bernhard
> > 
> > 
> >> On 19.01.2016, at 21:31, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
> >> 
> >> Make sure it compiles, and perform a mouse operation with a modifier key 
> >> (JP did an alt+block-select - rotate block - in eeschema).
> >> 
> >> On Tue, Jan 19, 2016 at 09:31:12PM +0100, Bernhard Stegmaier wrote:
> >>> Sorry, didn’t follow this thread… what exactly needs to be tested to see if it works?
> >>> I can give it a quick try then...
> >>> 
> >>> 
> >>> Regards,
> >>> Bernhard
> >>> 
> >>>> On 19 Jan 2016, at 21:15, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
> >>>> 
> >>>> Thanks. Since this particular bit has the potential to be 
> >>>> platform-dependent, I'd like if someone on OSX could test as well before 
> >>>> pushing.
> >>>> 
> >>>> On Tue, Jan 19, 2016 at 09:15:55PM +0100, jp charras wrote:
> >>>>> Le 19/01/2016 18:33, Chris Pavlina a écrit :
> >>>>>> Updated patch attached, tested on Linux 64 and Windows 64, works fine.
> >>>>>> 
> >>>>> 
> >>>>> Works fine now on W7 32 bits
> >>>>> 
> >>>>> 
> >>>>> -- 
> >>>>> Jean-Pierre CHARRAS
> >>>>> 
> >>>>> _______________________________________________
> >>>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>>> More help   : https://help.launchpad.net/ListHelp
> >>>> 
> >>>> _______________________________________________
> >>>> Mailing list: https://launchpad.net/~kicad-developers
> >>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>>> More help   : https://help.launchpad.net/ListHelp
> >>> 
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References