kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 1/22/2016 1:49 AM, Bernhard Stegmaier wrote:
> Hi,
> 
> any objections or problems with this patch so it didn’t get applied yet?
> Or, did it just get lost in some inboxes…

Is there any reason not to build this when using wxWidgets 3.1 or
greater?  I'm guessing the wxMagnifyEvents will only occur on platforms
that support them so building it will only create issues if we are
intercepting any of the other events that prevent the wxMagnifyEvents.
Most users will expect the magnify behavior to work correctly no matter
what platform they are using.  It would make for a cleaner patch rather
than using the conditional USE_OSX_MAGNIFY_EVENT definition.  I'm OK
with this patch but there may be other platforms that support
wxMagnifyEvents (I haven't looked at the source so I'm not sure) besides
OSX.

> 
> 
> Regards,
> Bernhard
> 
>> On 17 Jan 2016, at 22:00, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx> wrote:
>>
>> Hi,
>>
>> current mainline pinch-to-zoom support on OS X only works with a patched wxWidgets 3.0.
>> Pinch-to-zoom support now officially has arrived in wxWidgets master/3.1.
>> The attached patch also adds support for pinch-to-zoom with official (unpatched) wxWidgets master/3.1.
>> It should be safe for all platforms, because according to the documentation the new wxEVT_MAGNIFY event is only generated on OS X.
>>
>>
>> Regards,
>> Bernhard
>>
>> <0001-Add-support-for-wxEVT_MAGNIFY-on-official-wxWidgets-.patch>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>