kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 1/23/2016 2:05 AM, Bernhard Stegmaier wrote:
> It is just the other way round!?
> 
> wxWidgets 3.1 and above defines wxEVT_MAGNIFY for *all* patforms. 
> wxWidgets <3.1 doesn’t have this functionality *at all*.
> The wxCHECK_VERSION is IMHO the official way to check for wxWidgets >=
> 3.1, so this pieces of code will always compile when using wxWidgets >= 3.1.

That's what I meant if I did not state it clearly.

> 
> According to documentation for wxWidgets 3.1 currently it is only sent
> for OS X (so, it shouldn’t affect other platforms).
> However, the code should be safe also for other platforms that might use
> this event in future and thus additionally add support also for those
> then (when they implement it).
> 
> USE_OSX_MAGNIFY_EVENT is just a define from patch that is currently
> already submitted with which support for this event is back ported into
> wxWidgets-3.0. Currently, this patch is only used for OSX I guess (as
> its name suggests).
> Check for this is only kept for backwards compatibility with current
> implementation/patches.

I forgot we have a patch for wx 3.0.2 for this as well so we will have
to keep USE_OSX_MAGNIFY_EVENT for now.

I'll apply this patch sometime over the weekend.

Cheers,

Wayne

> 
> Of course, both the wxCHECK_VERSION and the USE_OSX_MAGNIFY_EVENT could
> be mangled into one single define, but I don’t see the point of this
> currently. If eventually minimum wx version will be 3.1, they will go
> away anyway.
> 
> 
> Regards,
> Bernhard
> 
>> On 22 Jan 2016, at 22:00, Wayne Stambaugh <stambaughw@xxxxxxxxx
>> <mailto:stambaughw@xxxxxxxxx>> wrote:
>>
>> On 1/22/2016 1:49 AM, Bernhard Stegmaier wrote:
>>> Hi,
>>>
>>> any objections or problems with this patch so it didn’t get applied yet?
>>> Or, did it just get lost in some inboxes…
>>
>> Is there any reason not to build this when using wxWidgets 3.1 or
>> greater?  I'm guessing the wxMagnifyEvents will only occur on platforms
>> that support them so building it will only create issues if we are
>> intercepting any of the other events that prevent the wxMagnifyEvents.
>> Most users will expect the magnify behavior to work correctly no matter
>> what platform they are using.  It would make for a cleaner patch rather
>> than using the conditional USE_OSX_MAGNIFY_EVENT definition.  I'm OK
>> with this patch but there may be other platforms that support
>> wxMagnifyEvents (I haven't looked at the source so I'm not sure) besides
>> OSX.
>>
>>>
>>>
>>> Regards,
>>> Bernhard
>>>
>>>> On 17 Jan 2016, at 22:00, Bernhard Stegmaier
>>>> <stegmaier@xxxxxxxxxxxxx <mailto:stegmaier@xxxxxxxxxxxxx>> wrote:
>>>>
>>>> Hi,
>>>>
>>>> current mainline pinch-to-zoom support on OS X only works with a
>>>> patched wxWidgets 3.0.
>>>> Pinch-to-zoom support now officially has arrived in wxWidgets
>>>> master/3.1.
>>>> The attached patch also adds support for pinch-to-zoom with official
>>>> (unpatched) wxWidgets master/3.1.
>>>> It should be safe for all platforms, because according to the
>>>> documentation the new wxEVT_MAGNIFY event is only generated on OS X.
>>>>
>>>>
>>>> Regards,
>>>> Bernhard
>>>>
>>>> <0001-Add-support-for-wxEVT_MAGNIFY-on-official-wxWidgets-.patch>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>