kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

When I fix project file selection for this, how should I do it? Do we want to
ditch the file selection dialog and just save to the current project file, or
keep the selection dialog and respect the selection?

On Fri, Jan 22, 2016 at 03:47:31PM -0500, Wayne Stambaugh wrote:
> On 1/18/2016 1:59 PM, jp charras wrote:
> > Le 18/01/2016 19:28, Wayne Stambaugh a écrit :
> > 
> > << snipped >>
> > 
> >>> If you want to enhance the .pro file, add also in this file the path of
> >>> the saved gerber and drill files (Eeschema already save the path of plot
> >>> files).
> >>
> >> Makes sense to save these at the project level.
> >>
> >>>
> >>> It could be worth to know this path when running Gerbview from Kicad.
> >>> The path and all other plot prms is already saved in the .kicad_pcb
> >>> file, but this is not a very good idea (at least for some of them).
> >>> The right place is the .pro file, not the board file, because these
> >>> parameters can be used outside Pcbnew.
> >>
> >> It's probably too late to move these settings from the board file.  I
> >> don't want to break the board file format to change this.  Moving
> >> forward, I would prefer that project related settings be saved in the
> >> .pro file rather than the board and/or schematic file.  I've never been
> >> fond of the fact that my board file changes when I change the plot
> >> settings or the change layer visibility because I use a VCS for version
> >> control.
> > 
> > I am not sure it is too late.
> > Moving some of these settings breaks anything.
> > 
> > 1- They can be saved both in board file and .pro file
> > or:
> > 2 - They can be just missing in board file and saved only in .pro file
> > (but obviously, the code to read (skip?) these parameters in board files
> > should not be removed)
> 
> The problem is when they are in both places, which one takes precedence.
>  We've had issues with this in the past where some setting was being
> saved the board file and in the app settings which resulted in some
> unexpected behavior.  If we stop saving them in the board file, we will
> have to make sure we remove all of the code that updates the settings
> from the board file.  In the short term, we can leave the the file
> parameters as is and a least fix the project file issues.  Saving
> parameters in the board or schematic files is something we should
> discuss at a later date and make a policy decision about how we want to
> handle them.
> 
> > 
> > New .pro files can be read by old versions (new parameters are just
> > ignored, they use the old .ini file format)
> > 
> > Some parameters must be saved in board file because they are part of the
> > design (vias are tented or not tented, or the plot origin).
> > 
> > Most of them should be moved to the .pro (options like "use Protel
> > extension", "list of layers to plot", or the latest file format : PDF,
> > Gerber ... used for instance)
> > 
> > Removing them from the board files does not break anything.
> > Just if an user loads the board file with an old Pcbnew version, he will
> > reselect these options.
> > And most of time they need to be reselected, to plot a doc in PS or PDF
> > format and then create fab Gerber/Drill files.
> > 
> > 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp