← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH v2 0/3] Correctly split patch

 

Simon,

Have you tested this patch on MSYS and/or MSYS2?  The last time we went
through this exercise, FindwxWidgets.cmake was broken on msys builds.  I
would rather avoid going through that again.  Also, do I apply the first
9 patches than the 3 patches from this set and should I apply them all
and just have single commit which seems to make the most sense.

Thanks,

Wayne

On 2/13/2016 7:16 PM, Simon Richter wrote:
> Hi,
> 
> this is the same patch, correctly split and without the change that
> replaces CMAKE_HOST_UNIX with CMAKE_CROSSCOMPILING -- will check on that
> with CMake upstream as well.
> 
> This also shifts some line numbers around -- in case later patches no
> longer apply cleanly, I can just send the entire stack as internally
> consistent patches again.
> 
>    Simon
> 
> Simon Richter (3):
>   FindwxWidgets.cmake: drop a few dbg_msg invocations
>   FindwxWidgets.cmake: Add comment describing code block
>   FindwxWidgets.cmake: Treat CygWin as unix rather than undefined
> 
>  CMakeModules/FindwxWidgets.cmake | 23 ++---------------------
>  1 file changed, 2 insertions(+), 21 deletions(-)
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References