kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 2/15/2016 12:16 PM, Simon Richter wrote:
> Hi Wayne,
> 
> Am 15.02.2016 um 17:17 schrieb Wayne Stambaugh:
> 
>> Have you tested this patch on MSYS and/or MSYS2?
> 
> Yes, I've tested that with MSYS2. The difference to the previous patch
> are the parts that went to the cmake developers list:
> 
>  - fix the case where multiple CXXFLAGS that are neither -D nor -I are
> returned from wx-config
>  - use cygpath to translate from weird hybrid path (C:/msys64/...) to
> Windows path (C:\msys64\...).
> 
> This means we still have a few changes that aren't in upstream, and the
> CMake people seem unsure whose fault it is -- the MSYS people
> deliberately changed wx-config to return hybrid paths instead of Unix
> style (which probably explains why the MSYS support in the upstream
> FindwxWidgets.cmake does not work -- it used to before).
> 
>> The last time we went through this exercise, FindwxWidgets.cmake was broken on msys builds.
> 
> Indeed, but we can now ask Jenkins to test a patch.
> 
>> Also, do I apply the first
>> 9 patches than the 3 patches from this set and should I apply them all
>> and just have single commit which seems to make the most sense.
> 
> The "v2" set replaces the incorrectly split [2/19] patch. I can prepare
> a branch if that is easier.

If you don't mind.  That would make my life a lot easier than having to
apply all of these patches individually.

Thanks,

Wayne

> 
>    Simon
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>