← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] No GAL FPS Limiting for OS X

 

Hi Bernhard,

I have just pushed your patch (rev 6560). It is better to avoid #ifdefs
if possible, but I am not able to provide a better solution at the
moment and your changes have a positive impact on the overall
performance. Thank you for taking care of the problem.

Regards,
Orson

On 02/12/2016 02:14 PM, Bernhard Stegmaier wrote:
> Hi Orson,
> 
> I just tried with some ThinkPad mouse I have from my work laptop on my MacBook.
> Panning seems to be fine with that mouse with and without the timer (panning with the usual shift/ctrl-scrollwheel).
> Especially, there are no hangs with the timer.
> 
> 
> Regards,
> Bernhard
> 
>> On 12 Feb 2016, at 14:06, Maciej Sumiński <maciej.suminski@xxxxxxx> wrote:
>>
>> Hi Bernhard,
>>
>> I see your patch significantly affects the performance, but I need to
>> know one thing before I apply it. Does panning work fine with other
>> input devices (i.e. ones that do not send events with high frequency)?
>> If so, then maybe we should have a second look at the
>> wx_view_controls.cpp #ifdef instead.
>>
>> Regards,
>> Orson
>>
>> On 02/08/2016 08:16 PM, Bernhard Stegmaier wrote:
>>> If you want to get an impression… here
>>>  https://drive.google.com/open?id=0Bxxu6Mh3pHubZ3BGSjFGNV9oYXc
>>> is a small video with the touchpad panning I am currently working on.
>>>
>>> First part is with timer, second without.
>>> Watch my fingers in the first part… yes, they do move even if KiCad does nothing and jumps somewhere when I stop panning.
>>> If you move incredibly slow, panning follows fingers on touchpad.
>>>
>>>> On 08 Feb 2016, at 18:56, Garth Corral <gcorral@xxxxxxxxx> wrote:
>>>>
>>>> Some devices provide what are termed precise scrolling deltas and generate a far greater number of scrolling events.  The trackpad is such a device.  Cocoa events have a hasPreciseScrollingDeltas method that will provide this information.  It is used in wxWidgets window.mm, for instance, when translating NSEvents to wx events. 
>>>>
>>>> Garth
>>>>
>>>>> On Feb 8, 2016, at 9:31 AM, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx> wrote:
>>>>>
>>>>>
>>>>>> On 08 Feb 2016, at 18:18, Maciej Sumiński <maciej.suminski@xxxxxxx> wrote:
>>>>>>>
>>>>>>
>>>>>> Does it mean the issue depends on the input device?
>>>>>
>>>>> AFAIK yes.
>>>>> “Normal” mice seem to produce much less events than Mac devices.
>>>>>
>>>>> Especially my MacBook touchpad is very sensitive and usual zoom is pretty useless with it.
>>>>> If you only slightly touch it you scroll min to max.
>>>>>
>>>>> For zoom there is even some special #ifdef’d “slowdown” in the code.
>>>>> It works quite OK with a Magic/Mighty Mouse, but still is bad with touchpads.
>>>>>
>>>>> With only native Mac gear KiCad has IMHO a pretty bad UI experience (compared to native OS X programs).
>>>>>
>>>>>
>>>>> Regards,
>>>>> Bernhard
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>
>>
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References