kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 17/02/2016 21:27, Simon Richter a écrit :
> 
> The bitmask requires a mapping to a different type used for the combobox,
> and only few of the enumeration values actually make sense.
> 
> This removes the mapping, and uses a the same numbering throughout the
> entire code.
> ---
>  eeschema/dialogs/dialog_lib_edit_pin.cpp |   2 +-
>  eeschema/dialogs/dialog_lib_edit_pin.h   |   4 +-
>  eeschema/lib_pin.cpp                     | 219 ++++++++++++++++++-------------
>  eeschema/lib_pin.h                       |  54 +++-----
>  eeschema/pinedit.cpp                     |  20 +--
>  5 files changed, 164 insertions(+), 135 deletions(-)

Simon,

Thanks for your work.

Could you modify your changes to be compliant with our coding style
policy, when changing enum names?

DrawPinShape enum is an old name.

but PinShape is not compliant. it should be at least PINSHAPE.

However, to tell the true, I prefer more significant names, in this case
something like
GRAPHIC_PINSHAPE.

(PINSHAPE, PINTYPE are the kind of names which can be applied to a lot
of parameters, this the reason I prefer a better name)

Also can you group yours patches relative to the same thing (5 patches
to move an enum in a header and change its name is too much for me).

Thanks.

-- 
Jean-Pierre CHARRAS