← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] New Feature: Touchpad Panning

 

On 2/22/2016 8:57 AM, Tomasz Wlostowski wrote:
> On 20.02.2016 13:56, Bernhard Stegmaier wrote:
>> Any plans/comments whether this one will get merged?
> 
> Hi Bernard,
> 
> I don't have a Mac, so I can't test the OSX changes myself, but as no
> one among the OSX Kicad has complained for the last 2 weeks, I'd vote
> for merging it...

Has any one tested it on windows and/or linux?  There are quite a few
changes that are not OSX specific so we need to make sure it doesn't
break the existing behavior before I commit it.  I'll try to test it
today on windows.

> 
> Cheers,
> Tom
>>
>>> On 12.02.2016, at 20:38, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx> wrote:
>>>
>>> Hi all,
>>>
>>> attached a patch to add a new feature “touchpad panning”.
>>> When enabled, you can pan in x/y-direction by just using usual 2-finger touchpad gestures without shift/ctrl modifiers instead of scroll wheel zoom.
>>>
>>> It is particularly useful on OS X, because any Apple touchpad/mouse supports these 2-finger gestures (1-finger with MagicMouse). 
>>> It makes KiCad behave more like any other regular OS X application and has been requested for some time by some/many OS X users.
>>>
>>> It is built on top of platform independent wxWidgets functions, so it should work also on any other platform and device supporting x/y mousewheel events and is not restricted to OS X.
>>>
>>> I added preference options to each application like the other pan/zoom options (and a menu entry for 3d-Viewer).
>>> If disabled, panning/scrolling should work the same as without the patch.
>>>
>>> I tested it on
>>> * OS X with touchpad, MagicMouse, MightMouse
>>> * OS X with normal PC mouse
>>> * Linux running inside a VirtualBox on OS X (debian testing with xfce desktop)
>>>
>>> I would be great if someone could test it on native Windows/Linux with a touchpad.
>>> It should be OK, the only problem that I could imagine is that panning speed might have to be adapted (frequency/granularity of mousewheel events could be different between OS X and other platforms, there are already some platform specific adaptions in the code before the patch).
>>>
>>> Of course, any other feedback is also welcome!
>>>
>>> Note:
>>> This patch contains the patch discussed in the other mail thread, which disables framerate throttling in GAL on OS X.
>>>
>>>
>>> Regards,
>>> Bernhard
>>>
>>> <osx-tg.patch>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


References