← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] New Feature: Touchpad Panning

 

The retina patch is unrelated.
It should (still) apply without any conflicts (I guess/hope, I didn’t try).
If it doesn’t, I can generate a new one.

Attached a new patch against rev6578.


Regards,
Bernhard

Attachment: touchpad-panning.patch
Description: Binary data



> On 22.02.2016, at 16:42, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
> 
> Bernhard,
> 
> I'll wait until this evening that way I can test it on linux and
> windows.  Does the touchpad panning patch need to be applied before the
> retina patch?
> 
> Thanks,
> 
> Wayne
> 
> On 2/22/2016 10:08 AM, Bernhard Stegmaier wrote:
>> Sure, no problem. I'll send an updated version this evening.
>> 
>> You also could pull it directly from
>>  https://github.com/bstegmaier75/kicad-source-mirror/tree/touchpad-panning
>> Updated this weekend...
>> 
>> 
>> Regards,
>> Bernhard
>> 
>> On 2016-02-22 15:34, Wayne Stambaugh wrote:
>>> Bernhard,
>>> 
>>> This patch no longer applies cleanly.  Would you please rebase it so I
>>> can test it?
>>> 
>>> Thanks,
>>> 
>>> Wayne
>>> 
>>> On 2/20/2016 7:56 AM, Bernhard Stegmaier wrote:
>>>> Any plans/comments whether this one will get merged?
>>>> 
>>>>> On 12.02.2016, at 20:38, Bernhard Stegmaier
>>>>> <stegmaier@xxxxxxxxxxxxx> wrote:
>>>>> 
>>>>> Hi all,
>>>>> 
>>>>> attached a patch to add a new feature “touchpad panning”.
>>>>> When enabled, you can pan in x/y-direction by just using usual
>>>>> 2-finger touchpad gestures without shift/ctrl modifiers instead of
>>>>> scroll wheel zoom.
>>>>> 
>>>>> It is particularly useful on OS X, because any Apple touchpad/mouse
>>>>> supports these 2-finger gestures (1-finger with MagicMouse).
>>>>> It makes KiCad behave more like any other regular OS X application
>>>>> and has been requested for some time by some/many OS X users.
>>>>> 
>>>>> It is built on top of platform independent wxWidgets functions, so
>>>>> it should work also on any other platform and device supporting x/y
>>>>> mousewheel events and is not restricted to OS X.
>>>>> 
>>>>> I added preference options to each application like the other
>>>>> pan/zoom options (and a menu entry for 3d-Viewer).
>>>>> If disabled, panning/scrolling should work the same as without the
>>>>> patch.
>>>>> 
>>>>> I tested it on
>>>>> * OS X with touchpad, MagicMouse, MightMouse
>>>>> * OS X with normal PC mouse
>>>>> * Linux running inside a VirtualBox on OS X (debian testing with
>>>>> xfce desktop)
>>>>> 
>>>>> I would be great if someone could test it on native Windows/Linux
>>>>> with a touchpad.
>>>>> It should be OK, the only problem that I could imagine is that
>>>>> panning speed might have to be adapted (frequency/granularity of
>>>>> mousewheel events could be different between OS X and other
>>>>> platforms, there are already some platform specific adaptions in the
>>>>> code before the patch).
>>>>> 
>>>>> Of course, any other feedback is also welcome!
>>>>> 
>>>>> Note:
>>>>> This patch contains the patch discussed in the other mail thread,
>>>>> which disables framerate throttling in GAL on OS X.
>>>>> 
>>>>> 
>>>>> Regards,
>>>>> Bernhard
>>>>> 
>>>>> <osx-tg.patch>
>>>>> 
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>> 
>>>> 
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp


Follow ups

References