kicad-developers team mailing list archive

[Clemens Koller <cko@xxxxxxxxx>]

Hello, Wayne!

On 2016-02-22 20:23, Wayne Stambaugh wrote:
> Anyone else see any issues with this patch?  I just tested it on windows
> and I didn't see any issues.  Since this only seems to be an issue on
> OSX, maybe we should wrap this in an #ifdef/#endif as much as I don't
> like them.

I don't see a reason to wrap that. Don't draw a zero sized object seems
to be fair. I would even consider to emit a warning in debug mode when this
triggers...

Regards,

Clemens

> 
> On 2/20/2016 8:13 AM, Bernhard Stegmaier wrote:
>> Hi,
>>
>> attached a patch to fix lp:1529159, it is still reproducible with a current wxWidgets master.
>> Credits go to the author of the bug report, I just did change the condition to immediately return if one of the sizes is zero (and create the patch).
>>
>> Of course, it could be argued if the real fix for this should go into OS X wxWidgets (I guess it should), but not trying to draw something zero sized at all doesn’t seem like a bad thing in general.
>>
>>
>> Regards,
>> Bernhard
>>
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>