kicad-developers team mailing list archive

[Eldar Khayrullin <eldar.khayrullin@xxxxxxx>]

Result

> On Feb 23 2016, at 3:29 pm, Eldar Khayrullin
<eldar.khayrullin@xxxxxxx> wrote:  
Apply Justify of text and flipped flag of text from import file.  

>

>> On Feb 23 2016, at 12:00 pm, Eldar Khayrullin
<eldar.khayrullin@xxxxxxx> wrote:  
Hello.

>>

>> I rebase patches.

>>

>> PS: All sizes in Kicad internal units.

>>

>>> On Feb 22 2016, at 9:35 pm, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:  

>>>

>>> Eldar,

>>>

>>> There is something unsettling about your patch. Why are there different  
scalars applied when calculating the length of the text versus the  
height? This would suggest the PCAD file format does not use the same  
units for text height, text width, and text position. It appears to me  
that you have determined the text position and size scalars by comparing  
the KiCad output with the output of some other EDA application. If the  
PCAD units are mm, inches, mils, etc, the size and position numbers  
should be scaled to nanometers which are the units used in Pcbnew. When  
I see things like / 3, / 1.8, and / 1.4 in two consecutive lines of code  
translating coordinates, that raises a red flag.

>>>

>>> Cheers,

>>>

>>> Wayne

>>>

>>> On 2/22/2016 11:56 AM, Eldar Khayrullin wrote:  
> Hello. Patch attached.  
> P.S. need work to correct a justification of text and text size (I do)  
>  
>  
> _______________________________________________  
> Mailing list: https://launchpad.net/~kicad-developers  
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx  
> Unsubscribe : https://launchpad.net/~kicad-developers  
> More help : https://help.launchpad.net/ListHelp  
>

>>>

>>> _______________________________________________  
Mailing list: https://launchpad.net/~kicad-developers  
Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx  
Unsubscribe : https://launchpad.net/~kicad-developers  
More help : https://help.launchpad.net/ListHelp