← Back to team overview

kicad-developers team mailing list archive

Re: 3D refactor

 

Thanks Bernhard,

Before I committed the 3D refactor, I was going to ask our package devs
to take a look at it due to the new 3D model plugins.  I would like to
get this correct before I commit it.  What's the status on windows.
I've built and installed from source and that works find but I'm
guessing our installers will need to be changed to accommodate this.
Once we have the install issues sorted out, I'll commit it.

Cheers,

Wayne

On 2/24/2016 12:26 PM, Bernhard Stegmaier wrote:
> Hi,
> 
> I just tried on OS X and plugin handling doesn’t seem to be OK.
> At least, “make install” does directly (try to) install them to
> “/Applications/…” which is completely wrong (and also maybe the case why
> my built binary doesn’t find them?). Also, the path itself under
> SharedSupport I guess isn’t right.
> 
> It also install this here
> bstegmaier$ ls -al /Applications/kicad.app/Contents/Macos/
> total 464
> drwxr-xr-x  4 bstegmaier  admin     136 24 Feb 18:17 .
> drwxr-xr-x  3 bstegmaier  admin     102 24 Feb 18:17 ..
> -rwxr-xr-x  1 bstegmaier  admin  231560 24 Feb 18:17
> libkicad_3dsg..0.0.dylib
> lrwxr-xr-x  1 bstegmaier  admin      24 24 Feb 18:17 libkicad_3dsg.dylib
> -> libkicad_3dsg..0.0.dylib
> which doesn’t look right, what is it good for?
> 
> If you like, I can have a look and try to fix this.
> 
> 
> Regards,
> Bernhard
> 
>> On 23.02.2016, at 22:21, Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx
>> <mailto:cirilo.bernardo@xxxxxxxxx>> wrote:
>>
>>
>>
>> On Tue, Feb 23, 2016 at 7:37 PM, jp charras <jp.charras@xxxxxxxxxx
>> <mailto:jp.charras@xxxxxxxxxx>> wrote:
>>
>>     Le 23/02/2016 08:56, Cirilo Bernardo a écrit :
>>     > On Tue, Feb 23, 2016 at 3:00 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
>>     > wrote:
>>     >
>>     >> Cirilo,
>>     >>
>>     >> I have one last change request that I missed in my previous review.
>>     >> Please change your debugging output method.  Windows apps have no
>>     >> concept of stdout even when run from the command line.  wxLogTrace is
>>     >> the preferred method for debugging output.  It solves two problems.  The
>>     >> debugging strings are redirected to the correct output on all supported
>>     >> platforms and the debugging output is turned off by default.  Turning on
>>     >> the debugging output is as simple as:
>>     >>
>>     >> export WXTRACE="SOME_DEBUGGING_OUTPUT_TO_ENABLE"
>>     >>
>>     >> The is handy so I don't have to sift through everyone's debugging output
>>     >> to find what I'm looking for.  You just need to pick a unique string not
>>     >> used by any other kicad wxLogTrace calls to enable tracing of your
>>     >> debugging output.
>>     >>
>>     >>
>>     > The 3d_initial_merge branch has been updated to use wxLogTrace;
>>     > it has also been synchronized to the main branch r6527.  The latest
>>     > revision for the 3d_initial_merge branch is r6527. The branch builds
>>     > successfully and I have tested the previewer with various VRML1/2 and
>>     > X3D models.
>>     >
>>     > - Cirilo
>>
>>     Thanks, Cirilo.
>>     Very good work.
>>
>>     At least on Windows, 3d_plugin_manager.cpp is missing the line:
>>     #include <wx/filename.h>
>>
>>     Without this include, it does not compile.
>>
>>     --
>>     Jean-Pierre CHARRAS
>>
>>     _______________________________________________
>>     Mailing list: https://launchpad.net/~kicad-developers
>>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>     Unsubscribe : https://launchpad.net/~kicad-developers
>>     More help   : https://help.launchpad.net/ListHelp
>>
>>
>> Thanks Jean-Pierre,
>>
>>  I have added the header and checked that it builds on Windows (W7-64
>> bit).
>>
>> - Cirilo
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References