← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] New Feature: Touchpad Panning

 

Hi Mario,

what canvas are you talking about?
What do you mean with “in steps of 6 / -6”?


Regards,
Bernhard

> On 25 Feb 2016, at 23:10, Mário Luzeiro <mrluzeiro@xxxxx> wrote:
> 
> Hi Wayne, Bernhard,
> 
> I am not sure if this patch is correct.
> I updated my trunk kicad and install it (to make sure I was using the trunk version)
> 
> First if I select the option and scroll with mouse, it will jump in the Y in steps of 6 / -6 .. but I am not sure how it is supposed to work (I dont have a compatible? touchpad)
> Second, I think it breaks the previous function of vertical / horizontal scrolling:
> 
> because if I (uncheck the option and) press shift / ctrl.. I also got that 6/-6 steps..
> also it only work for Y.. and not for X
> 
> http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/view/head:/3d-viewer/3d_canvas.cpp#L284
> 
> So I think for my case the
> if( event.GetWheelAxis() == wxMOUSE_WHEEL_HORIZONTAL )
> 
> is not horizontal when I press the shift and scroll..
> 
> Would you mind to verify?
> 
> Thanks!
> Mario
> 
> ________________________________________
> From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx] on behalf of Wayne Stambaugh [stambaughw@xxxxxxxxx]
> Sent: 24 February 2016 19:56
> To: Bernhard Stegmaier
> Cc: KiCad Developers
> Subject: Re: [Kicad-developers] [PATCH] New Feature: Touchpad Panning
> 
> Patch committed in r6586.  Thanks!
> 
> Wayne
> 
> On 2/23/2016 12:25 PM, Bernhard Stegmaier wrote:
>> 
>>> On 23.02.2016, at 17:44, Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx> wrote:
>>> 
>>>> * The touchpad panning is not implemented in the component viewer,
>>>> component editor, footprint viewer, and footprint editor.  I would think
>>>> that we would want it implemented in these windows for the sake of
>>>> consistency.  I image the first bug report filed against this patch will
>>>> be about that.
>>> 
>>> Strange, all of them work for me on OS X, both with legacy and GAL canvas.
>>> I’ll retest on Linux.
>>> 
>>> I currently couldn’t imagine any reason why it shouldn’t work in Windows…
>>> The changes are just in the EDA_DRAW_PANEL classes.
>>> Are they different on Windows?
>> 
>> I just verified on my Debian/Xfce (via VirtualBox on OS X) and all of them
>> do work with touchpad-panning.
>> 
>> What is the problem with it?
>> Doesn’t it pan at all?
>> 
>> As said in the other mail these are the same events as for the scroll-wheel.
>> So, if the touchpad in general works with touchpad-panning disabled and
>> using shift/ctrl modifiers, it should also be OK with it enabled.
>> There is no platform magic involved...
>> 
>> 
>> Regards
>> Bernhard
>> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References