← Back to team overview

kicad-developers team mailing list archive

[PATCH 0/8] Totally uncontroversial portability patches

 

Hi,

The only thing that is somewhat ugly is the s/ssize_t/ptrdiff_t/ in
potrace. This is basically what upstream did in the 1.13 release. The other
patches are fairly straightforward, I think, and mostly result from
diagnostics that a compiler that shall remain unnamed spits out where gcc
simply ignores the error.

   Simon

Simon Richter (8):
  Make locale init counter unsigned
  Use Windows-style DLL import/export for all Windows compilers
  Use PATH to search for shared libraries on Windows
  Add missing C++ stdlib headers
  Open namespace around definitions
  Use ptrdiff_t in potrace instead of ssize_t
  Avoid C99 style compound statement
  Avoid conflicting declaration for Pgm()

 common/common.cpp                              |  2 +-
 common/gal/graphics_abstraction_layer.cpp      |  2 ++
 common/grid_tricks.cpp                         |  2 ++
 common/selcolor.cpp                            |  2 ++
 common/tool/action_manager.cpp                 |  1 +
 eeschema/autoplace_fields.cpp                  |  5 ++++-
 eeschema/class_library.h                       |  2 ++
 eeschema/dialogs/dialog_lib_edit_pin_table.cpp |  2 ++
 eeschema/sch_sheet_path.h                      |  2 ++
 gerbview/class_GERBER.cpp                      |  1 +
 include/common.h                               |  2 +-
 include/import_export.h                        |  2 +-
 include/kiway.h                                |  4 +++-
 include/pgm_base.h                             |  2 --
 include/tool/tool_event.h                      |  1 +
 include/tool/tool_manager.h                    |  1 +
 kicad/files-io.cpp                             |  2 +-
 kicad/kicad.cpp                                |  9 ++++++++-
 kicad/mainframe.cpp                            |  8 ++++----
 kicad/menubar.cpp                              |  6 +++---
 kicad/pgm_kicad.h                              |  3 ++-
 kicad/prjconfig.cpp                            |  8 ++++----
 pcb_calculator/transline/transline.cpp         |  1 +
 pcbnew/layer_widget.cpp                        |  3 +++
 pcbnew/ratsnest_data.h                         |  2 ++
 pcbnew/ratsnest_viewitem.cpp                   |  4 +++-
 pcbnew/router/pns_diff_pair.cpp                |  1 +
 pcbnew/router/pns_optimizer.cpp                |  2 ++
 pcbnew/router/pns_utils.cpp                    |  2 ++
 pcbnew/tools/conditional_menu.h                |  1 +
 pcbnew/tools/edit_points.h                     |  3 +++
 polygon/math_for_graphics.cpp                  |  1 +
 potrace/bitmap.h                               | 15 ++++++++-------
 potrace/greymap.cpp                            |  2 +-
 potrace/greymap.h                              |  3 ++-
 utils/idftools/idf_common.cpp                  |  1 +
 36 files changed, 79 insertions(+), 31 deletions(-)

-- 
2.1.4


Follow ups