kicad-developers team mailing list archive

[Nick Østergaard <oe.nick@xxxxxxxxx>]

Den 28/02/2016 19.34 skrev "Bernhard Stegmaier" <stegmaier@xxxxxxxxxxxxx>:
>
> Hi,
>
> while testing the touchpad-panning for the recent 3d-viewer fixes I
noticed, that non-touchpad-panning using shift/ctrl-wheel and a normal PC
mouse seems to be broken on OS X with legacy canvas.
>
> It only pans horizontal regardless whether you press shift or ctrl.
> This is already the case in the official 4.0.1, so it has nothing to do
with my changes.
>
> Debugging this I noticed that obviously wxWidgets or OS X change the
wheel axis from vertical (0) without shift (or, while pressing ctrl) to
horizontal (1) when pressing shift.
>
> So, this piece of code (draw_panel.cpp, line 985ff):
>
>         if( event.ShiftDown() && !event.ControlDown() )
>
>         {
>
>             if( axis == 0 )
>
>                 cmd.SetId( ID_PAN_UP );
>
>             else
>
>                 cmd.SetId( ID_PAN_RIGHT );
>
>         }
>
>         else if( event.ControlDown() && !event.ShiftDown() )
>
>             cmd.SetId( ID_PAN_LEFT );
>
>
> will do a pan left/right when shift is pressed (because axis==1) instead
of horizontal as it should.
>
> Question is… why is this “if( axis == 0 )” in there (and, only for the
shift case)?
> Any special purpose?

I think Garth also noticed this, but I don't know what he did or whether or
not he found a reason for this.

> Of course, I could fix this by adding a OS X specific #ifdef, which
reverts the change of the axis on shift being pressed.
> However, if the axis would be just ignored in the shift-case like in the
ctrl-case, it would work without any #ifdef (not tested):
>
> if( event.ShiftDown() && !event.ControlDown() )
>
>             cmd.SetId( ID_PAN_UP );
>
>         else if( event.ControlDown() && !event.ShiftDown() )
>
>             cmd.SetId( ID_PAN_LEFT );
>
>
> That’s basically what GAL does (ignoring axis, just looking at shift/ctrl
modifiers) and that’s why it works there.
> However, I don’t know if any intended functionality gets lost with that
change.
> Maybe something like touchpad-panning when pressing shift, but zoom
without any modifier?
>
>
> Regards,
> Bernhard
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>