kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 3/1/2016 10:49 AM, Simon Wells wrote:
> Hey Wayne
> 
> For what reasons are you not thrilled with putting it in the
> about_dialog? even on linux/windows i can't say i can remember an
> application which has copy version info in the menu structure.
> 
> The main reason i reimplemented it in the about dialog class was due
> to wanting/expecting it to be removed from the help menu. The only
> missing information currently i believe is the ABI information which
> can be added easily enough, one of the problems i see with the current
> implementation is its all based on build time information and ignores
> run time (for wx mine does the opposite) i can also easily add the
> curl stuff which i don't believe is in the current implementation.

If you're going to remove the existing copy version info from the
exiting help menus than I'm OK with adding it to the about dialog.

Either call EDA_BASE_FRAME::CopyVersionInfoToClipboard() from the about
dialog (I believe all of our top level windows are derived from
EDA_BASE_FRAME), make it static, or move the code to the about dialog
source.  Keeping two copies of this around will only create maintenance
headaches.

If you are going to use the wxWidgets run time information, please
create a new line so we can see the wxWidgets build vs run time info.
It could prove useful.

Please add the libcurl info.  I thought it was already in there.

> 
> thanks
> 
> Simon
> 
> 
> On Wed, Mar 2, 2016 at 4:18 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>> Simon,
>>
>> I'm not thrilled with adding the copy version info button to the about
>> box.  The information you are copying to the clipboard is incomplete and
>> I don't want users the think this is the version information that we
>> want included in bug reports.  I don't understand why you wouldn't have
>> just called EDA_BASE_FRAME::CopyVersionInfoToClipboard().  At least it
>> would be the same information.  The rest of the changes are fine.
>>
>> Cheers,
>>
>> Wayne
>>
>> On 2/29/2016 1:45 PM, Simon Wells wrote:
>>> Attached is a patch that modifies a few things in the About dialog, a
>>> screenshot with old and new is also attached
>>>
>>> It removes the horizontal rule which is redundant due to the auinotebook
>>> Adds Copy Version Info to the about box which i think is a better
>>> place for it than in the help menu esspecially on OSX where about
>>> isn't even in the help menu (I haven't removed the menu items yet  am
>>> interested to hear other peoples thoughts on whether it is used often
>>> enough to keep it in the main menu bar as well) due to this the code
>>> is currently in 2 places.
>>> I have also changed the about dialog (and version info from the about
>>> box) change to use the currently running version of wxwidgets rather
>>> than the version that kicad was built with unfortunately this is not
>>> possible with boost
>>>
>>> Simon
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp