← Back to team overview

kicad-developers team mailing list archive

Re: Trouble with BOM plugin execution on Windows

 

Le 18/03/2016 22:17, Константин Барановский a écrit :
> Parameter like --show-console will be passed to bom generator (bom_tool.exe
> in example), but we need tell wxExecute to run command with flag
> wxEXEC_SHOW_CONSOLE. And I propose "!" sign at begining of the command line
> to indicate that it must be run with that flag, it may be checked like it
> done with pythonw in bom_pythonw_exec.patch.

This is our code.
This command line is analyzed by Kicad (to expand %I and others).
A specific option can be filtered and set a wxExecute option like
wxEXEC_SHOW_CONSOLE (or some other).

> 
> 2016-03-18 21:46 GMT+02:00 jp charras <jp.charras@xxxxxxxxxx>:
> 
>> Le 18/03/2016 19:11, Константин Барановский a écrit :
>>> What if realize it through the command line of the BOM plugin in the next
>>> way :
>>> "bom_tool.exe %I %O" - execute and hide window (by default);
>>> "!bom_tool.exe %I %O" - execute and show window.
>>> Yes, it is not intuitive, but it is rare case and, I think, is
>> acceptable.
>>> What do you think?
>>
>> Why to reinvent the wheel?
>>
>> there are more usual ways to force an option.
>> for instance, in command line executables, an option is usually called
>> by something like:
>> --show_console
>>
>> Whatever the option, do not forget to update the on help line called by
>> the help button in dialog.
>>
>>>
>>> 2016-03-18 18:02 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>>>
>>>> I don't think setting the wxEXEC_SHOW_CONSOLE for a single executable
>>>> name (in the case of your patch pythonw(.exe)) is a good idea.  The
>>>> problem I foresee is someone will want launch executables X, Y, and Z
>>>> and soon this code would spiral out of control.  I would rather not add
>>>> pet behavior patches and come up with a more robust solution.  A better
>>>> patch would be to add an option to the BOM generator dialog to always
>>>> show the console for a given BOM generator configuration.  This way you
>>>> can use any executable and configure accordingly.
>>
>>
>>
>> --
>> Jean-Pierre CHARRAS
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 


-- 
Jean-Pierre CHARRAS


Follow ups

References