kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Patch committed in r6634. Thank you.

On Mon, Mar 21, 2016 at 12:22:07PM +1100, Cirilo Bernardo wrote:
> The attached patch makes the following changes to import DXF:
> 
> 1. correctly implements scaling based on DXF $INSUNITS -
> at least where INSUNITS is sensible. I ignore units like miles,
> gigameters, AU, lightyear, parsec ...
> 
> 2. correctly implements LWPolylines, adding an ARC segment
> rather than a line segment when bulge != 0.  A number of users
> have been complaining about getting the wrong board shape
> (chamfered corners rather than rounded corners) on DXF Import,
> now they shouldn't complain.
> 
> The patch has been made against the main branch r6633. I
> have tested polylines with +/- bulge and arcs < 180deg and
> > 180 deg. I think I have covered all cases of arcs but if anyone
> has DXF test files with special cases, please try them.
> 
> The patch is small enough and fixes significant bugs so I
> think it should be considered for inclusion in a Stable fix.
> Due to a more recent commit in the main branch (r6630)
> a little care is required applying to the Stable branch as
> this patch undoes the changes in r6630.
> 
> I can't find any bug reports affected by this patch using
> 'dxf' as the sole search criterion.
> 
> - Cirilo