← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Enable C++11

 

We should hold off on using any c++11 specific code for a while just in
case we have to remove this patch.  If we make it a month without having
to pull the patch, then we can start using c++11 stuff.

On 3/21/2016 11:27 AM, Chris Pavlina wrote:
> Someone should probably ask - apologies if someone already did: Do you have a
> policy in mind for using C++11 features in new patches? It may be prudent to
> let the patch settle for a few days just to make sure nobody else has build
> trouble before we start making it harder to back out.
> 
> On Mon, Mar 21, 2016 at 11:13:26AM -0400, Wayne Stambaugh wrote:
>> Going, going, gone!  Since I haven't gotten any objections, I committed
>> the patch to enable C++11.  Thanks Simon for the patch but be prepared
>> for the grumbling. :)
>>
>> On 3/18/2016 3:42 PM, Wayne Stambaugh wrote:
>>> I tested this on my Debian testing and it seemed fine.  It is 2016 after
>>> all so I guess it's time to jump into the C++11 waters if there are no
>>> objections.  I figure we'll be good to roll out C++14 in 2019 or 2020. :).
>>>
>>> On 3/18/2016 12:08 AM, Simon Richter wrote:
>>>> Hi Wayne,
>>>>
>>>> On 17.03.2016 20:35, Wayne Stambaugh wrote:
>>>>
>>>>> @Simon, when cmake is < 3.1 you set the -std-c++11 flag for gcc and
>>>>> clang instead of the -gnu-c++11.  This seems to be an issue that should
>>>>> be addressed.  Maybe this is what is breaking @Mark's builds.  I would
>>>>> feel more comfortable if we figure this out before I commit the patch.
>>>>
>>>> It works for me on Debian jessie, with cmake 3.0.2 and gcc 4.9.2, and on
>>>> Ubunty trusty with cmake 2.8.12.2 and gcc 4.8.2.
>>>>
>>>> On Ubuntu trusty, wxPython 3.0 is not available as far as I can see, so
>>>> that build was without scripting support.
>>>>
>>>>    Simon
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


References