kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Yes, ! is a valid file name character on at /least/ Linux, therefore this is broken.

On Mon, Mar 21, 2016 at 07:00:02PM -0400, Wayne Stambaugh wrote:
> Using ! is not going to be intuitive for most users.  This may make
> sense for developers who are used to cryptic symbols and identifiers but
> the typical user isn't going to get this.  Isn't ! a valid file name
> character on Linux?  I don't think this solution is user friendly so I'm
> standing by my original proposal.
> 
> On 3/19/2016 3:26 PM, Константин Барановский wrote:
> > bom_gen_tool.exe --option1 --option2 %I %O --show_console
> > 
> > Command line looks like all options is pushed to bom_gen_tool.exe and
> > not obvious that --show_console used to wxExecute.
> > For me it less intuitive than "!" symbol at beginning of the command line. 
> > 
> > 2016-03-19 16:23 GMT+02:00 jp charras <jp.charras@xxxxxxxxxx
> > <mailto:jp.charras@xxxxxxxxxx>>:
> > 
> >     Le 18/03/2016 22:17, Константин Барановский a écrit :
> >     > Parameter like --show-console will be passed to bom generator (bom_tool.exe
> >     > in example), but we need tell wxExecute to run command with flag
> >     > wxEXEC_SHOW_CONSOLE. And I propose "!" sign at begining of the command line
> >     > to indicate that it must be run with that flag, it may be checked like it
> >     > done with pythonw in bom_pythonw_exec.patch.
> > 
> >     This is our code.
> >     This command line is analyzed by Kicad (to expand %I and others).
> >     A specific option can be filtered and set a wxExecute option like
> >     wxEXEC_SHOW_CONSOLE (or some other).
> > 
> >     >
> >     > 2016-03-18 21:46 GMT+02:00 jp charras <jp.charras@xxxxxxxxxx
> >     <mailto:jp.charras@xxxxxxxxxx>>:
> >     >
> >     >> Le 18/03/2016 19:11, Константин Барановский a écrit :
> >     >>> What if realize it through the command line of the BOM plugin in
> >     the next
> >     >>> way :
> >     >>> "bom_tool.exe %I %O" - execute and hide window (by default);
> >     >>> "!bom_tool.exe %I %O" - execute and show window.
> >     >>> Yes, it is not intuitive, but it is rare case and, I think, is
> >     >> acceptable.
> >     >>> What do you think?
> >     >>
> >     >> Why to reinvent the wheel?
> >     >>
> >     >> there are more usual ways to force an option.
> >     >> for instance, in command line executables, an option is usually
> >     called
> >     >> by something like:
> >     >> --show_console
> >     >>
> >     >> Whatever the option, do not forget to update the on help line
> >     called by
> >     >> the help button in dialog.
> >     >>
> >     >>>
> >     >>> 2016-03-18 18:02 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx
> >     <mailto:stambaughw@xxxxxxxxx>>:
> >     >>>
> >     >>>> I don't think setting the wxEXEC_SHOW_CONSOLE for a single
> >     executable
> >     >>>> name (in the case of your patch pythonw(.exe)) is a good idea.  The
> >     >>>> problem I foresee is someone will want launch executables X, Y,
> >     and Z
> >     >>>> and soon this code would spiral out of control.  I would rather
> >     not add
> >     >>>> pet behavior patches and come up with a more robust solution. 
> >     A better
> >     >>>> patch would be to add an option to the BOM generator dialog to
> >     always
> >     >>>> show the console for a given BOM generator configuration.  This
> >     way you
> >     >>>> can use any executable and configure accordingly.
> >     >>
> >     >>
> >     >>
> >     >> --
> >     >> Jean-Pierre CHARRAS
> >     >>
> >     >> _______________________________________________
> >     >> Mailing list: https://launchpad.net/~kicad-developers
> >     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >> Unsubscribe : https://launchpad.net/~kicad-developers
> >     >> More help   : https://help.launchpad.net/ListHelp
> >     >>
> >     >
> > 
> > 
> >     --
> >     Jean-Pierre CHARRAS
> > 
> > 
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp