← Back to team overview

kicad-developers team mailing list archive

Re: Make Cairo optional

 

Le 22/03/2016 16:11, Simon Wells a écrit :
> Due to the performance of cairo on many systems attached is a patch
> that makes the cairo canvas and cairo libs optional.
> 
> on osx this removes the need for the following libs
> 
> libX11 libXau LibXdmcp LibXext libXrender libcairo
> libfontconfig libfreetype libpixman libpng16.16 libxcb-render
> libxcb-shm libxcb
> 
> to be in the bundle. and reduces size by 14MB.
> 
> If cairo libs are found by cmake then it is compiled with cairo, and
> if the cairo libs are not found then  it is built without cairo
> support. This has mainly been changed by just removing the required
> field from the find_package(Cairo) in CMake and then some basic #ifdef
> changes and pcbnew/cmakelists to make the cairo sources conditional.
> 
> I would expect packagers to still build with all canvases but it may
> be useful for those that are only building for their machines.
> 
> Simon

I do not think this is a good idea.
I have many reasons:
* Cairo is not always very slow and is an alternative to OpenGL canvas,
which has sometimes issues.
* It could be a good canvas for Eeschema (better than Opengl).
* It could be needed for printing as an alternative to the current wxDC
canvas (wxDC has always issues for printing)
* I do not see any good reason to add a lot of #ifdef in code.



-- 
Jean-Pierre CHARRAS


Follow ups

References