kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

I like this, but I have a few comments to make.

1. Don't edit the dialogs/*base.cpp files - as they say at the top:

> C++ code generated with wxFormBuilder (version mumble mumble, mumble)
> PLEASE DO "NOT" EDIT THIS FILE!

No matter how tempting it may be to remove the quotes around "NOT" ;) The next
time someone edits the .fbp original, your edits will be lost.

2. There's a bug, if I set a text to Angled, then edit it again, the
Orientation is back to Vertical in the dialog.

3. We should either call it something other than "Angled", or actually allow
arbitrary (non-45deg) angles. It's a bit misleading, I was looking for the
entry field to type in my angle...

4. There may be quite a few places in the code that assume 90 degree
increments, as we've been restricted to that for years. This will have to be
tested pretty thoroughly.

All in all though, I've always thought it was pretty stupid to be limited this
way (in particular, I often want to put text on H and V even if a part itself
is angled), and I'm hugely in favor of this once it's cleaned up a bit and
tested.

On Thu, Mar 31, 2016 at 09:05:01PM +0000, Pereira, Patrick wrote:
> Hi,
> 
> With this patch it'll be possible to use angled text.
> 
> Best regards.