← Back to team overview

kicad-developers team mailing list archive

Re: Question about const SHAPE_LINE_CHAIN Outline() const

 

On 04/04/2016 01:39 PM, jp charras wrote:
> Sorry if you already sent me a response to this "old" message (first posted on feb 05)
> but I did not remember this response.
> 
> It is annoying for the rounded rect pads which use this method.
> (I currently use a fixed (modified) version in my patch)
> 
> I can easily fix it, but I do not want to create bugs in pns router.
> 
> Thanks.
> 
>> Orson, Tomasz,
>>
>> I am thinking there is a bug in geometry/shape_rect.h:
>> In
>> const SHAPE_LINE_CHAIN Outline() const
>>
>> m_h and m_w look like they are swapped in calculations, and the outline
>> is incorrect (assuming m_w is the X axis rect size (width), and m_h is
>> the Y axis rect size (height)).
>>
>> Can you have a look at this?
>>
>> Thanks

Hi Jean-Pierre,

Just by looking at the code, I am quite positive that you are right in
this matter, but Tom has to confirm it. He is absent today, so hopefully
he will respond tomorrow.

Regards,
Orson

Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups

References