kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Patch committed in rev 6666. Thank you.

On Thu, Apr 07, 2016 at 11:39:07AM +1000, Cirilo Bernardo wrote:
> This patch fixes a number of issues reported by the latest coverity scan;
> however it does not include a fix for one issue (I have asked Mario to help
> fix this remaining one):
> 
> ** CID 143741:  Memory - corruptions  (OVERRUN)
> /3d-viewer/common_ogl/cogl_att_list.cpp: 64 in COGL_ATT_LIST::
> GetAttributesList(bool)()
> 
> 
> Fixed issues related to the 3D merge:
> 
> ** CID 143752:  Incorrect expression  (USELESS_CALL)
> /3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp: 178
> in DLG_SELECT_3DMODEL::TransferDataFromWindow()()
> 
> *** CID 143751:  Incorrect expression  (UNUSED_VALUE)
> /plugins/3d/vrml/v1/vrml1_shapehints.cpp: 39
> in WRL1SHAPEHINTS::WRL1SHAPEHINTS(NAMEREGISTER *)()
> 
> *** CID 143749:  Uninitialized members  (UNINIT_CTOR)
> /plugins/3d/vrml/v1/vrml1_shapehints.cpp: 55
> in WRL1SHAPEHINTS::WRL1SHAPEHINTS(NAMEREGISTER *, WRL1NODE *)()
> 
> *** CID 143748:  Uninitialized members  (UNINIT_CTOR)
> /3d-viewer/3d_rendering/3d_render_ogl_legacy/c_ogl_3dmodel.cpp: 268
> in C_OGL_3DMODEL::C_OGL_3DMODEL(const S3DMODEL &)()
> 
> *** CID 143747:  Uninitialized members  (UNINIT_CTOR)
> /utils/idftools/dxf2idf.h: 35
> in DXF2IDF::DXF2IDF()()
> 
> *** CID 143746:  Uninitialized members  (UNINIT_CTOR)
> /3d-viewer/3d_rendering/3d_render_ogl_legacy/c3d_render_ogl_legacy.cpp: 45
> in C3D_RENDER_OGL_LEGACY::C3D_RENDER_OGL_LEGACY(CINFO3D_VISU &, S3D_CACHE
> *)()
> 
> *** CID 143745:  Uninitialized members  (UNINIT_CTOR)
> /plugins/3d/vrml/wrlproc.cpp: 59
> in WRLPROC::WRLPROC(LINE_READER *)()
> 
> *** CID 143744:  Uninitialized members  (UNINIT_CTOR)
> /3d-viewer/3d_model_viewer/c3d_model_viewer.cpp: 97
> in C3D_MODEL_VIEWER::C3D_MODEL_VIEWER(wxWindow *, const int *)()
> 
> *** CID 143740:  Null pointer dereferences  (NULL_RETURNS)
> /plugins/3d/vrml/x3d/x3d_appearance.cpp: 122
> in X3DAPP::readFields(wxXmlNode *)()
> 
> *** CID 143739:  Memory - corruptions  (MISMATCHED_ITERATOR)
> /3d-viewer/3d_cache/sg/scenegraph.cpp: 136
> in SCENEGRAPH::unlinkNode(const SGNODE *, bool)()
> 
> /3d-viewer/3d_cache/sg/scenegraph.cpp: 137
> in SCENEGRAPH::unlinkNode(const SGNODE *, bool)()
> 
> *** CID 143735:  Integer handling issues  (CONSTANT_EXPRESSION_RESULT)
> /plugins/3d/vrml/wrlproc.cpp: 169
> in WRLPROC::getRawLine()()
> 
> *** CID 143734:  Error handling issues  (CHECKED_RETURN)
> /3d-viewer/3d_cache/dialogs/dlg_select_3dmodel.cpp: 178
> in DLG_SELECT_3DMODEL::TransferDataFromWindow()()