← Back to team overview

kicad-developers team mailing list archive

Re: Custom shaped pads work. Second test.

 

Hi JP,

With the pad editor dialog in 6673 (i have looked at the changelogs
for 6674 and 6675 and can't see any changes to this) The new fields
you have added behave differently to the trapezoidal fields, mainly
that the text is set to disabled (or something) colour as well with
the corner radius part of the dialog. Can this be changed to match the
trapezoidal fields, as on OSX the only thing visible without tilting
my laptop screen well off axis is the primary text box which looks a
bit odd as can be seen in the attached image

thanks

Simon

On Fri, Apr 8, 2016 at 2:08 AM, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
> 2016-04-07 16:06 GMT+02:00 jp charras <jp.charras@xxxxxxxxxx>:
>> Le 07/04/2016 15:43, Nick Østergaard a écrit :
>>> Hi JP
>>>
>>> It seems that this was merged in 6671, thank your for your work on
>>> this, but I think you might have missed one crucial part to this.
>>> Namely the board file version bump. To me this does not look like this
>>> is backward compatible to 4.0.2 in any sensible way. (I have not
>>> tested nor reviewed the patch in detail, please correct me if I am
>>> wrong).  We should seriously take care that we are as backward
>>> compatible as we can be. At least the user shall be warned that
>>> opening a file made in a newer version will loose information.
>>>
>>> Nick
>>
>> - in rev 6671, I added only rounded rect pads feature.
>> the new (updated) patch add custom shaped pads, which are not in rev 6671, because they are not yet
>> mature.
>>
>> - As long rounded pads are not used, the board file is readable by 4.0.2.
>
> Yes, I understand this. But if I create a board with 6671 using round
> rect pads, and give it to a friend, he will not be able to open it
> properly and there lies the issue.
>
>>
>>>
>>> 2016-04-04 10:46 GMT+02:00 jp charras <jp.charras@xxxxxxxxxx>:
>>>> Attached, a second patch to test rounded rect and custom shaped pads.
>>>> (against rev bzr 6660)
>>>>
>>>> Changes from the first patch are
>>>> * bug fixes.
>>>> * some fixes in custom shaped pads dialogs.
>>>> * rounded rect pads more mature: one can set the corner radius ratio from 0% to 50%.
>>>> * Better dialog to set rounded rect and custom shaped pads parameters.
>>>>
>>>>
>>>> --
>>>> Jean-Pierre CHARRAS
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>
>>
>> --
>> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: Screen Shot 2016-04-09 at 04.02.42.png
Description: PNG image


Follow ups

References