kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Thank you. I've tested this and don't see any issues; I'm going to merge it.

Still think the dialog could use a bit of adjustment, but I'll do that myself
in the near future.

Thanks :)

On Fri, Apr 08, 2016 at 01:39:54PM +0000, Pereira, Patrick wrote:
> Hello,
> 
> I think that is everything ok now with this patch.
> Dialog window corrected.
> 
> Best Regards,
> ________________________________________
> De: Kicad-developers [kicad-developers-bounces+patrick.pereira=intel.com@xxxxxxxxxxxxxxxxxxx] em nome de Pereira, Patrick [patrick.pereira@xxxxxxxxx]
> Enviado: quinta-feira, 7 de abril de 2016 18:28
> Para: Chris Pavlina
> Cc: kicad-developers@xxxxxxxxxxxxxxxxxxx
> Assunto: [Kicad-developers] RES: RES:  [PATCH] new feature, value and reference with angle in PCB
> 
> tys Chris !
> I'll try to solve this if you not solved yet.
> 
> Best Regards,
> 
> ________________________________________
> De: Chris Pavlina [pavlina.chris@xxxxxxxxx]
> Enviado: terça-feira, 5 de abril de 2016 21:50
> Para: Pereira, Patrick
> Cc: kicad-developers@xxxxxxxxxxxxxxxxxxx
> Assunto: Re: RES: [Kicad-developers] [PATCH] new feature, value and reference with angle in PCB
> 
> Okay, I like this a lot more now.
> 
> I'm going to run my own build with this patch for a little while to make sure
> nothing else comes up. If not, and nobody else minds, I'll accept it.
> 
> The dialog looks a little bit off to me - there's some extra padding on the
> right that shouldn't be there by default. I'll have a look at that myself
> later, though if you know what the issue is I'd happily accept a fix :)
> 
> On Tue, Apr 05, 2016 at 10:26:08PM +0000, Pereira, Patrick wrote:
> > Hello,
> >
> > Some corrections to this path.
> >
> > Best regards.
> > ________________________________________
> > De: Chris Pavlina [pavlina.chris@xxxxxxxxx]
> > Enviado: quinta-feira, 31 de março de 2016 19:03
> > Para: Pereira, Patrick
> > Cc: kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Assunto: Re: [Kicad-developers] [PATCH] new feature, value and reference with angle in PCB
> >
> > I like this, but I have a few comments to make.
> >
> > 1. Don't edit the dialogs/*base.cpp files - as they say at the top:
> >
> > > C++ code generated with wxFormBuilder (version mumble mumble, mumble)
> > > PLEASE DO "NOT" EDIT THIS FILE!
> >
> > No matter how tempting it may be to remove the quotes around "NOT" ;) The next
> > time someone edits the .fbp original, your edits will be lost.
> >
> > 2. There's a bug, if I set a text to Angled, then edit it again, the
> > Orientation is back to Vertical in the dialog.
> >
> > 3. We should either call it something other than "Angled", or actually allow
> > arbitrary (non-45deg) angles. It's a bit misleading, I was looking for the
> > entry field to type in my angle...
> >
> > 4. There may be quite a few places in the code that assume 90 degree
> > increments, as we've been restricted to that for years. This will have to be
> > tested pretty thoroughly.
> >
> > All in all though, I've always thought it was pretty stupid to be limited this
> > way (in particular, I often want to put text on H and V even if a part itself
> > is angled), and I'm hugely in favor of this once it's cleaned up a bit and
> > tested.
> >
> > On Thu, Mar 31, 2016 at 09:05:01PM +0000, Pereira, Patrick wrote:
> > > Hi,
> > >
> > > With this patch it'll be possible to use angled text.
> > >
> > > Best regards.
> >
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp