kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Yup, the validator system is very slick, I like it. I'm liking a lot of this
new wx dialog stuff, which is interesting considering how much I otherwise
dislike wx :D

I'll have a look and see if it's been fixed upstream, though honestly if not,
the wxFloatingPointValidator is so simple it's probably about equal to
reimplement it totally as to try to subclass and fix the existing one...

On Mon, Apr 11, 2016 at 09:25:55AM -0400, Wayne Stambaugh wrote:
> Please use validators!  This goes along with my announcement about our
> dialog design.  Take look at the wxWidgets validator sample so you
> understand how transferring data to and from the dialog controls is
> designed in wxWidgets.  Done correctly, it will greatly simplify our
> dialog code.
> 
> Maybe you can derive from wxFloatingPointValidator to fix the broken
> behavior without having to write an entirely new validator.  If it's
> fixed upstream, you could always copy it.  It sucks that this will most
> likely be temporary code until we bump the wxWidgets version.
> 
> On 4/11/2016 9:12 AM, Chris Pavlina wrote:
> > Making a derivative entry box is silly. If wxFloatingPointValidator is broken
> > we should make a new wxValidator, not a new entry box, as that is the idiomatic
> > way to do this in wx. I'm sure Wayne would concur on that. I'd have no problem
> > developing that, too.
> > 
> > On Mon, Apr 11, 2016 at 03:09:33PM +0200, jp charras wrote:
> >> Le 11/04/2016 14:10, Chris Pavlina a écrit :
> >>> ...why would I make some special entry box for this? What's wrong with what
> >>> I've already done?
> >>
> >> Nothing really wrong, but:
> >>
> >> * At least on Windows, wxFloatingPointValidator does not work fine:
> >>   - as long you are using the default language, it works.
> >>   - if you are switching to an other language (in my case from French (default) to English, it does
> >> not work anymore (neither the '.' nor the ',' are accepted, you cannot enter a value with mantissa)
> >> This was already reported in a bug report (See https://bugs.launchpad.net/kicad/+bug/1568302).
> >> * in all other dialogs which accept floating point coordinates, both the separators are accepted (.
> >> or ,) and correctly parsed and the value is correctly converted, This is a very serious enhancement
> >> for guys like me who are living in countries using the ',' as separator.
> >>
> >> So, I agree with Lorenzo: a derivative entry box which works on Windows, handles both separators and
> >> returns the right value is better than a wxFloatingPointValidator which does not work very well.
> >>
> >>> On Apr 11, 2016 2:18 AM, "Lorenzo Marcantonio" <l.marcantonio@xxxxxxxxxxxxx>
> >>> wrote:
> >>>
> >>>> On Sat, Apr 09, 2016 at 10:37:43AM -0400, Chris Pavlina wrote:
> >>>>> Anyone mind if I go through and fix the "in 0.1 degrees" units that are
> >>>> all
> >>>>> over pcbnew? I don't see any reason why we can't let the user enter unit
> >>>>> degrees with a decimal point.
> >>>>
> >>>> Probably stems for avoiding floats around the code, which is a good
> >>>> idea... we sometime went thru horrible linear algebra things to avoid
> >>>> trigonometric code and the resulting rounding issues.
> >>>>
> >>>> If you really want to fix it I'd suggest to make a derivative entry box
> >>>> that handles it and returns the value in decidegrees. Look how the
> >>>> current 'mils/inch/mm' entry box does it to centralize the
> >>>> conversion/check.
> >>>>
> >>>> --
> >>>> Lorenzo Marcantonio
> >>>> CZ Srl - Parma
> >>>>
> >>
> >>
> >> -- 
> >> Jean-Pierre CHARRAS
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp