kicad-developers team mailing list archive

["Pereira, Patrick" <patrick.pereira@xxxxxxxxx>]

Ty for the explication Wayne,

If I understand this patch in attachment is a simple solution.
Can you please take a look now to I have sure that is everything right now ?

Best regards,
________________________________________
De: Kicad-developers [kicad-developers-bounces+patrick.pereira=intel.com@xxxxxxxxxxxxxxxxxxx] em nome de Wayne Stambaugh [stambaughw@xxxxxxxxx]
Enviado: terça-feira, 12 de abril de 2016 10:37
Para: kicad-developers@xxxxxxxxxxxxxxxxxxx
Assunto: Re: [Kicad-developers] [PATCH] first patch to solve Bug #1562617.

Patrick,

You are confusing hot keys with menu accelerators.  They are not the
same thing and cannot be used interchangeably.  Menu accelerators are
shortcuts for menu entries and preform no additional actions other than
the action that selecting the menu entry would provide.  Hot keys
typically provide additional actions at the current cursor location in
the drawing area.  Obviously if the cursor has a menu open, this cannot
happen because the drawing area is blocked by the menu.  Tool bars are
nothing more than always visible menu shortcuts but they provide the
exact same behavior and are typically mapped to the same event ID.  So
using hot keys in tool bar tool tips is wrong because you do not get the
same behavior.  I realize there are some tool bar buttons that do not
have menu entries but that is a different issue.

Cheers,

Wayne

On 4/11/2016 4:03 PM, Pereira, Patrick wrote:
> First patch to solve Bug #1562617.
> With this patch pcbnew shows shortcut in toolbar popup-tip.
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

From 866a5ae88f09571d4d27796e4c5d15b646772635 Mon Sep 17 00:00:00 2001
From: "Patrick J.P" <patrick.pereira@xxxxxxxxx>
Date: Tue, 12 Apr 2016 15:23:26 -0300
Subject: [PATCH 1/1] Patch to solve Bug #1562617

With this patch the menus have accelerators under the first letter.

Signed-off-by: Patrick J.P <patrick.pereira@xxxxxxxxx>
---
 include/menus_helpers.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/menus_helpers.h b/include/menus_helpers.h
index ace6be5..e6b9d75 100644
--- a/include/menus_helpers.h
+++ b/include/menus_helpers.h
@@ -68,7 +68,7 @@ static inline wxMenuItem* AddMenuItem( wxMenu*          aMenu,
 {
     wxMenuItem* item;
 
-    item = new wxMenuItem( aMenu, aId, aText, wxEmptyString, aType );
+    item = new wxMenuItem( aMenu, aId, "&"+aText, wxEmptyString, aType );
 
     if( aType == wxITEM_CHECK )
     {
-- 
2.8.0