← Back to team overview

kicad-developers team mailing list archive

Re: RES: [PATCH] first patch to solve Bug #1562617.

 

Nope, still not an accelerator.  What you are showing is an mnemonic.
This is a menu accelerator:

"Some menu text\tCtrl+N"

This assumes that there is no hot key definition.  There is already code
in KiCad to provide menu accelerators for hot keys.  It's called
AddHotkeyName().  This requires you to define the hot key correctly in
order to provide both a menu accelerator and a hot key.

On 4/12/2016 2:29 PM, Pereira, Patrick wrote:
> Ty for the explication Wayne,
> 
> If I understand this patch in attachment is a simple solution.
> Can you please take a look now to I have sure that is everything right now ?
> 
> Best regards,
> ________________________________________
> De: Kicad-developers [kicad-developers-bounces+patrick.pereira=intel.com@xxxxxxxxxxxxxxxxxxx] em nome de Wayne Stambaugh [stambaughw@xxxxxxxxx]
> Enviado: terça-feira, 12 de abril de 2016 10:37
> Para: kicad-developers@xxxxxxxxxxxxxxxxxxx
> Assunto: Re: [Kicad-developers] [PATCH] first patch to solve Bug #1562617.
> 
> Patrick,
> 
> You are confusing hot keys with menu accelerators.  They are not the
> same thing and cannot be used interchangeably.  Menu accelerators are
> shortcuts for menu entries and preform no additional actions other than
> the action that selecting the menu entry would provide.  Hot keys
> typically provide additional actions at the current cursor location in
> the drawing area.  Obviously if the cursor has a menu open, this cannot
> happen because the drawing area is blocked by the menu.  Tool bars are
> nothing more than always visible menu shortcuts but they provide the
> exact same behavior and are typically mapped to the same event ID.  So
> using hot keys in tool bar tool tips is wrong because you do not get the
> same behavior.  I realize there are some tool bar buttons that do not
> have menu entries but that is a different issue.
> 
> Cheers,
> 
> Wayne
> 
> On 4/11/2016 4:03 PM, Pereira, Patrick wrote:
>> First patch to solve Bug #1562617.
>> With this patch pcbnew shows shortcut in toolbar popup-tip.
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 



References