← Back to team overview

kicad-developers team mailing list archive

Re: RES: [PATCH] Logic reformulation in Plot_Edges_Modules

 

I agree. I'm against committing this simply because I think it doesn't add
anything, though I do see the intent behind it.

On Wed, Apr 13, 2016 at 11:03:45AM -0500, José Ignacio wrote:
> Looking at the change in context, it might be a slight improvement in
> readability, using a positive vs a double negative, it's still mostly
> a no-op though. that logic is so simple it shouldn't be confusing
> either way when read in context.
> 
> On Wed, Apr 13, 2016 at 9:53 AM, Pereira, Patrick
> <patrick.pereira@xxxxxxxxx> wrote:
> > Ooooops, sorry for my inattention.
> >
> > Correction in attachment.
> >
> > ________________________________________
> > De: Kicad-developers [kicad-developers-bounces+patrick.pereira=intel.com@xxxxxxxxxxxxxxxxxxx] em nome de Lorenzo Marcantonio [l.marcantonio@xxxxxxxxxxxxx]
> > Enviado: quarta-feira, 13 de abril de 2016 3:19
> > Para: Kicad Developers
> > Assunto: Re: [Kicad-developers] [PATCH] Logic reformulation in Plot_Edges_Modules
> >
> > On Tue, Apr 12, 2016 at 09:16:00PM +0000, Pereira, Patrick wrote:
> >> Hi,
> >>
> >> Corrections to avoid unnecessary boolean operations
> >> !(!a || !b) = a || b
> >
> > You just insulted DeMorgan :D Hope the code is better
> >
> > --
> > Lorenzo Marcantonio
> > CZ Srl - Parma
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References