kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #24235
Re: PATCH: 3D filename resolver
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
Wayne Stambaugh <stambaughw@xxxxxxxxx>
-
Date:
Sat, 16 Apr 2016 08:34:32 -0400
-
In-reply-to:
<CAHBNN+M5cTpPXEVSt7EtKQ3QQod+pRmy4jMvGsXo5RmNgg=jpw@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2
Cirilo,
Does this patch fix any reported bugs? I seem to remember one filed
about 3D model file paths but I cannot find anything directly related to
this patch. I have it ready to commit but before I commit it I want to
make sure I don't have to link it to a bug report.
Thanks,
Wayne
On 4/15/2016 7:10 PM, Cirilo Bernardo wrote:
> The attached patch makes the following changes:
>
> 1. Paths defined via pcbnew->Preferences->Configure Paths
> are now included in the 3D file browser's drop-down list except
> for KICAD_PTEMPLATES, KIGITHUB, KISYSMOD, any paths
> resembling a URL, and any non-existent paths. When an
> absolute path is shortened using one of these path aliases,
> let's say 'KISYS3DMOD' then the name appears in the pcb file
> as "${KISYS3DMOD}/blah.wrl". If a user defines and actual
> environment variable with the same name, then that user
> defined variable will have precedence over the internally defined
> variable.
>
> 2. Paths relative to the current project directory are no longer
> represented as "some/path/to/file.wrl"; for compatibility with
> previous kicad versions it shall always be stored as
> ${KIPRJMOD}/some/path/to/file.wrl.
>
> 3. Various restrictions on alias path values have been removed
> since the imposed restrictions could result in corrupted user
> data (aliases are silently dropped).
>
> Overall the patch should improve back-compatibility by
> providing a ${ENV_VAR} mechanism for supporting
> different model root directories and ensuring that paths
> relative to KIPRJMOD are expressed in a way that is
> compatible with earlier kicad versions. This allows users
> more flexibility and the ability to work in a way that ensures
> 3D model files can be correctly resolved in earlier versions
> of kicad. Users who do not care about back-compatibility
> may prefer to use the newer alias system.
>
> - Cirilo
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Follow ups
References