← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: 3D filename resolver

 

Cirilo,

Thanks.  I committed your patch in r6697.

Cheers,

Wayne

On 4/16/2016 6:51 PM, Cirilo Bernardo wrote:
> Hi Wayne,
> 
>  As far as I know the patch only fixes latent (unreported) bugs and
> improves the compatibility with previous versions of KiCad. Nick has
> pointed me to some users' posts regarding behavior which they considered
> a bug and which is fixed by this patch, but I don't know of any bugs
> reported to launchpad.
> 
> - Cirilo
> 
> 
> On Sat, Apr 16, 2016 at 10:34 PM, Wayne Stambaugh <stambaughw@xxxxxxxxx
> <mailto:stambaughw@xxxxxxxxx>> wrote:
> 
>     Cirilo,
> 
>     Does this patch fix any reported bugs?  I seem to remember one filed
>     about 3D model file paths but I cannot find anything directly related to
>     this patch.  I have it ready to commit but before I commit it I want to
>     make sure I don't have to link it to a bug report.
> 
>     Thanks,
> 
>     Wayne
> 
>     On 4/15/2016 7:10 PM, Cirilo Bernardo wrote:
>     > The attached patch makes the following changes:
>     >
>     > 1. Paths defined via pcbnew->Preferences->Configure Paths
>     > are now included in the 3D file browser's drop-down list except
>     > for KICAD_PTEMPLATES, KIGITHUB, KISYSMOD, any paths
>     > resembling a URL, and any non-existent paths. When an
>     > absolute path is shortened using one of these path aliases,
>     > let's say 'KISYS3DMOD' then the name appears in the pcb file
>     > as "${KISYS3DMOD}/blah.wrl". If a user defines and actual
>     > environment variable with the same name, then that user
>     > defined variable will have precedence over the internally defined
>     > variable.
>     >
>     > 2. Paths relative to the current project directory are no longer
>     > represented as "some/path/to/file.wrl"; for compatibility with
>     > previous kicad versions it shall always be stored as
>     > ${KIPRJMOD}/some/path/to/file.wrl.
>     >
>     > 3. Various restrictions on alias path values have been removed
>     > since the imposed restrictions could result in corrupted user
>     > data (aliases are silently dropped).
>     >
>     > Overall the patch should improve back-compatibility by
>     > providing a ${ENV_VAR} mechanism for supporting
>     > different model root directories and ensuring that paths
>     > relative to KIPRJMOD are expressed in a way that is
>     > compatible with earlier kicad versions. This allows users
>     > more flexibility and the ability to work in a way that ensures
>     > 3D model files can be correctly resolved in earlier versions
>     > of kicad. Users who do not care about back-compatibility
>     > may prefer to use the newer alias system.
>     >
>     > - Cirilo
>     >
>     >
>     > _______________________________________________
>     > Mailing list: https://launchpad.net/~kicad-developers
>     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     > Unsubscribe : https://launchpad.net/~kicad-developers
>     > More help   : https://help.launchpad.net/ListHelp
>     >
> 
> 
>     _______________________________________________
>     Mailing list: https://launchpad.net/~kicad-developers
>     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>     Unsubscribe : https://launchpad.net/~kicad-developers
>     More help   : https://help.launchpad.net/ListHelp
> 
> 



Follow ups

References