kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Please excuse my fat fingers.  That should be 6440.

On 5/5/2016 11:04 AM, Chris Pavlina wrote:
> I do hope you didn't intent to credit Dick for 6640, that one's mine! ;)
> 
> On Thu, May 05, 2016 at 10:57:34AM -0400, Wayne Stambaugh wrote:
>> On 5/5/2016 10:47 AM, Chris Pavlina wrote:
>>> On Thu, May 05, 2016 at 10:15:02AM -0400, Wayne Stambaugh wrote:
>>>> [snip]
>>>>
>>>> I didn't see any credit to Dick for the work he did on libcurl
>>>> transition so that will need to be added to commit message.
>>>
>>> Hm, did he write any of the code in these patches?
>>
>> If any code from commits 6640 (which I forgot to give Dick credit for),
>> 6538, or 6467 was backported, then yes Dick needs to be in the credits.
>>
>>>
>>>>
>>>> On 5/5/2016 4:39 AM, Simon Richter wrote:
>>>>> Hi,
>>>>>
>>>>> this backports Mark's avhttp -> libcurl transition to the stable series.
>>>>> With these, I've been able to build a stable version of KiCad with the
>>>>> GitHub plugin enabled that does not link against OpenSSL, which should
>>>>> allow everyone to ship binaries with the Github plugin enabled.
>>>>>
>>>>>    Simon
>>>>>
>>>>> Mark Roszko (2):
>>>>>   Replace the avhttp library used by the github plugin with libcurl.
>>>>>   Replace avhttp with libcurl: Some fixes:     1. Fixed an assumption
>>>>>     somebody originally made in the plugin that std::string had
>>>>>     contiguous storage. This is not specced behavior pre C++11 so we
>>>>>     gamble by calling .reserve() which should give a far better
>>>>>     guarantee.     2. Added copy to clipboard information for curl    
>>>>>     3. Removed some openssl references in compiling.md     4. Renamed
>>>>>     struct vars to be uppercase to match "public var" code style policy
>>>>>
>>>>> Simon Richter (2):
>>>>>   Add missing dependency github_plugin -> pcbcommon
>>>>>   Remove unused FindOpenSSL.cmake
>>>>>
>>>>>
>>>>>  CMakeLists.txt                         |   5 +
>>>>>  CMakeModules/FindOpenSSL.cmake         | 342 ---------------------------------
>>>>>  Documentation/development/compiling.md |  12 +-
>>>>>  common/CMakeLists.txt                  |   6 +-
>>>>>  common/basicframe.cpp                  |   3 +
>>>>>  common/kicad_curl/kicad_curl.cpp       |  80 ++++++++
>>>>>  common/kicad_curl/kicad_curl_easy.cpp  | 163 ++++++++++++++++
>>>>>  common/pgm_base.cpp                    |   9 +
>>>>>  include/kicad_curl/kicad_curl.h        |  89 +++++++++
>>>>>  include/kicad_curl/kicad_curl_easy.h   | 166 ++++++++++++++++
>>>>>  pcbnew/CMakeLists.txt                  |   2 +
>>>>>  pcbnew/github/CMakeLists.txt           |  41 +---
>>>>>  pcbnew/github/github_getliblist.cpp    |  69 ++++---
>>>>>  pcbnew/github/github_getliblist.h      |   4 +-
>>>>>  pcbnew/github/github_plugin.cpp        | 152 +++------------
>>>>>  pcbnew/github/github_plugin.h          |   6 +-
>>>>>  16 files changed, 601 insertions(+), 548 deletions(-)
>>>>>  delete mode 100644 CMakeModules/FindOpenSSL.cmake
>>>>>  create mode 100644 common/kicad_curl/kicad_curl.cpp
>>>>>  create mode 100644 common/kicad_curl/kicad_curl_easy.cpp
>>>>>  create mode 100644 include/kicad_curl/kicad_curl.h
>>>>>  create mode 100644 include/kicad_curl/kicad_curl_easy.h
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp