← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 0/4] Backport libcurl code from development branch

 

Just a note… I may be wrong, but I guess for OS X this is only true if you build against the curl supplied by OS X natively?

My builds per default always pick the one from MacPorts, which links against OpenSSL or GnuTLS (depending on MacPorts config)… in this case I guess you will see the same problems as for other platforms.

I just checked Adams last build and they do seem to pick the native one, so indeed official OS X builds should be safe.


Regards,
Bernhard

> On 05 May 2016, at 19:18, Mark Roszko <mark.roszko@xxxxxxxxx> wrote:
> 
> You don't need openssl locking for OSX >= 10.9. curl uses Apple Common Crypto.
> 
> Other platforms may need it depending on Linux distro (some have
> dropped openssl for curl, some haven't).
> 
> On Thu, May 5, 2016 at 12:17 PM, Adam Wolf
> <adamwolf@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Simon,
>> 
>> Is the OpenSSL locking workaround something we know we'll need for the
>> libcurl backport?  If so, do we have someone who can work on it?
>> 
>> I can set up a build for this whenever it's needed.
>> 
>> Adam Wolf
>> 
>> On Thu, May 5, 2016 at 10:26 AM, Simon Richter <Simon.Richter@xxxxxxxxxx>
>> wrote:
>>> 
>>> Hi Wayne,
>>> 
>>> On 05.05.2016 16:15, Wayne Stambaugh wrote:
>>> 
>>>> Thanks Simon!  Nice work.  I just tested this on windows and it appears
>>>> to work fine.  I'm assuming you tested this on Linux.
>>> 
>>> Yes, briefly. These are just the two "switch to CURL" patches from the
>>> devel branch, and one small fix, so not much of the credit is mine here.
>>> 
>>>> Would one of our
>>>> osx devs please apply these patches to the 4 stable branch and make sure
>>>> that it builds and works correctly on osx?  Once I finish vetting Chris`
>>>> file versioning patch, I'll apply that to the stable release and push a
>>>> 4.0.3 stable release so the github plugin can be enabled.
>>> 
>>> Hm, I didn't pull in the OpenSSL locking workaround for OSX, so it's not
>>> that trivial, apparently.
>>> 
>>>> I didn't see any credit to Dick for the work he did on libcurl
>>>> transition so that will need to be added to commit message.
>>> 
>>> I've taken over the original commit messages from the commits I
>>> cherry-picked.
>>> 
>>>   Simon
>>> 
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>> 
>> 
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>> 
> 
> 
> 
> -- 
> Mark
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



Follow ups

References