← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] pcbnew legacy: remove option to hide via drill

 

On Tue, May 10, 2016 at 08:02:35PM +0200, jp charras wrote:
> Le 10/05/2016 à 18:28, Chris Pavlina a écrit :
> > [snip]
> 
> This is an opinion, which can be discussed.
> 
> AFAIK, since a long time the default via hole diameter does not exist. You can change the netclass
> drill diameter without changing the via drill diameter of existing vias.
> Therefore I do not see the problem you want to fix.
> 
> (The default via hole diameter can exist only in old boards)

Interesting, so I misunderstood the behavior. It seems that when Show Via Holes
is set to "Defined holes", via holes are hidden when they match the netclass,
despite the size actually being fixed (change the netclass size and they do not
change, only whether or not they are displayed changes).

Okay, so it seems like the setting is broken now anyway, probably since default
diameters were removed. Anyone object to me merging this, then?

Given that the vias *are* fixed, I don't see a need to have a way to separately
display this at all now, though we can certainly discuss it. That's different
from this patch though, I'd still like to get it merged.

> 
> > 
> > Honestly I think the behavior needs to go away entirely and be replaced with a
> > new way to make drills match the net class. Orson suggested to me that there
> > could be a way to manually trigger an update of drill sizes. In GAL this can
> > already be done on a selection. I'd like a way to update all drills of a
> > certain size, though - for instance a quick "change drills that had the old
> > netclass size to the new netclass size". Thoughts?
> > 
> > PLEASE, I'd like some input from people who actually do layout professionally,
> > if any are presently stalking the mailing list. The question of whether or not
> > things should change dynamically tends to be very important to them and I'd
> > like to know what they think.
> > 
> > [1] https://misc.c4757p.com/pad/p/pcbnew-prefs
> > 
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 
> -- 
> Jean-Pierre CHARRAS
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References