← Back to team overview

kicad-developers team mailing list archive

Re: Updated FindPython cmake modules

 

heres the patch

On Sat, May 21, 2016 at 10:49 AM, Simon Wells <swel024@xxxxxxxxx> wrote:
> Please find attached updated patch that removes
> CMakeModules/CMakeFindFrameworks.cmake
>
> Adam if you can test the patch it would be useful
>
> but based on when that file was last changed (in 2013) and is the same
> in the ubuntu 14.04 cmake 2.8.12 distribution  as it is in 3.5 which i
> use i don't think it should be an issue at all
>
> Simon
>
> On Thu, May 19, 2016 at 6:40 PM, Simon Wells <swel024@xxxxxxxxx> wrote:
>> Included are updated FindPython cmake modules, Using the current
>> FindPython*.cmake files with the mingw modifications from in tree. I
>> have been unable to test the mingw versions as i do not have a mingw
>> environment set up
>>
>> The reason i have updated these as currently the scripts first looks
>> for the version thats specified, aka FindPythonInterp 2.6 will prefer
>> version 2.6 to 2.7 so if both are installed then it requires
>> specifying. The new script i believe first checks the system python.
>> Again i am not sure if this will break mingw but i think it would be
>> better to modify the new version regardless.
>>
>> As part of this would it be better if we only included a
>> FindPythonInterp for mingw as it seems we only need the customisation
>> for mingw and we are losing the ability to just use updated scripts
>> for other operating systems
>>
>> Simon

Attachment: kicad_findpython-v2.patch
Description: Binary data


Follow ups

References