kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 26/05/2016 à 08:54, Simon Richter a écrit :
> 
> The same class is defined below the 3d_rendering/ directory as well, with
> more functionality.
> ---
>  3d-viewer/3d_draw.cpp            |   2 +-
>  3d-viewer/3d_draw_board_body.cpp |   2 +-
>  3d-viewer/CImage.cpp             | 440 ---------------------------------------
>  3d-viewer/CImage.h               | 190 -----------------
>  3d-viewer/CMakeLists.txt         |   1 -
>  5 files changed, 2 insertions(+), 633 deletions(-)
>  delete mode 100644 3d-viewer/CImage.cpp
>  delete mode 100644 3d-viewer/CImage.h

Cirilo,

Can you see if the patch (removing CImage.xx and using only cimage.xx) can be applied "as this", or
if some other changes are needed (because there are small differences between the 2 files)

Clearly there is duplicated code, and on Windows, using filenames which differs only by letter case
is not really a good idea.

Thanks.


-- 
Jean-Pierre CHARRAS