kicad-developers team mailing list archive

[Simon Wells <swel024@xxxxxxxxx>]

This patch isn't actually very good in its current state so i am
currently rewriting it.

@Wayne, I notied the MINGW stuff you added including lines that search
${CURRENT_VERSION}.1-9 is that even worth it any more with the primary
python2 distribution being 2.7.11?

The FindPythonInterp i am writing will search python2 then python then
python2.latest and going older until it hits one, However before
accepting a version it will test its version and make sure that major
is the same and major.minor is equal to or greater than the value
provided in Python_FIND_VERISON.

As i do not know all the pitfalls behind MINGW but have picked up a
bit from the script is requestion 'python' a bad idea on MINGW?

thanks

Simon

On Sat, May 21, 2016 at 10:50 AM, Simon Wells <swel024@xxxxxxxxx> wrote:
> heres the patch
>
> On Sat, May 21, 2016 at 10:49 AM, Simon Wells <swel024@xxxxxxxxx> wrote:
>> Please find attached updated patch that removes
>> CMakeModules/CMakeFindFrameworks.cmake
>>
>> Adam if you can test the patch it would be useful
>>
>> but based on when that file was last changed (in 2013) and is the same
>> in the ubuntu 14.04 cmake 2.8.12 distribution  as it is in 3.5 which i
>> use i don't think it should be an issue at all
>>
>> Simon
>>
>> On Thu, May 19, 2016 at 6:40 PM, Simon Wells <swel024@xxxxxxxxx> wrote:
>>> Included are updated FindPython cmake modules, Using the current
>>> FindPython*.cmake files with the mingw modifications from in tree. I
>>> have been unable to test the mingw versions as i do not have a mingw
>>> environment set up
>>>
>>> The reason i have updated these as currently the scripts first looks
>>> for the version thats specified, aka FindPythonInterp 2.6 will prefer
>>> version 2.6 to 2.7 so if both are installed then it requires
>>> specifying. The new script i believe first checks the system python.
>>> Again i am not sure if this will break mingw but i think it would be
>>> better to modify the new version regardless.
>>>
>>> As part of this would it be better if we only included a
>>> FindPythonInterp for mingw as it seems we only need the customisation
>>> for mingw and we are losing the ability to just use updated scripts
>>> for other operating systems
>>>
>>> Simon