← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add mime package for gerber and excellon files

 

Le 31/05/2016 à 19:17, José Ignacio a écrit :
> We can add that other pattern too, they all get tested, it's not an
> all or nothing comparison. Ie: if it has a .gbr extension with any
> text/plain content it will match as a gerber file. if it has any
> extension but starts with G04 it will match as a gerber file, we can
> add <match value="%.TF" type="string" offset="0"/> so that it will
> match X2 files that do not have a .gbr extension, or we could just
> remove the magic section and not match any files that do not have .gbr
> extension. We could add the common protel extensions as additional
> glob sections but i think it's worse considering that they are not
> even registered anywhere and the space for 3 letter extensions is
> pretty saturated (chances are there are other programs using them)

The pattern "%" (no more) can (and should) be added (as long as the "match" fields is really useful).

Like you, I do not think adding common Protel extensions is acceptable, because:
- they are really stupid (and dead, in 2016, from my point of view extensions)
- AFAIK (but I can be wrong) Protel is not a FOSS.
I am not a FOSS fundamentalist, but ...

-- 
Jean-Pierre CHARRAS


Follow ups

References