kicad-developers team mailing list archive

[Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>]

The attached patch fixes CID 149046 (dead code).

=== modified file 'plugins/3d/vrml/v2/vrml2_shape.cpp'
--- plugins/3d/vrml/v2/vrml2_shape.cpp	2016-05-20 01:12:07 +0000
+++ plugins/3d/vrml/v2/vrml2_shape.cpp	2016-06-03 00:13:46 +0000
@@ -490,22 +490,11 @@
     if( NULL != appearance )
         pApp = appearance->TranslateToSG( pShape );
 
-    if( ( NULL != appearance && NULL == pApp ) || NULL == pGeom )
+    if( NULL != appearance && NULL == pApp )
     {
-        if( pGeom )
-        {
-            IFSG_FACESET tmp( false );
-            tmp.Attach( pGeom );
-            tmp.Destroy();
-        }
-
-        if( pApp )
-        {
-            IFSG_APPEARANCE tmp( false );
-            tmp.Attach( pApp );
-            tmp.Destroy();
-        }
-
+        IFSG_FACESET tmp( false );
+        tmp.Attach( pGeom );
+        tmp.Destroy();
         shNode.Destroy();
         return NULL;
     }