← Back to team overview

kicad-developers team mailing list archive

[PATCH 00/16] Simple patches

 

Hi,

this is a stack of simple patches that should not actually have much of an
effect on the generated code -- these are mostly cleanups and readability
improvements.

These should be ready to be merged, given that I've been using a build with
these included for quite some time now.

   Simon

Simon Richter (16):
  Fix spelling "propage" -> "propagate"
  Add missing dependency github_plugin -> pcbcommon
  Clarify ERC: we're iterating netlist items, not nets
  Explain how ERC works.
  Cache netlist item during ERC
  Check sorting of netlist during ERC
  Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets
  Drop extra copy ctors from IFSG_NODE
  Replace boost::shared_ptr with std::shared_ptr
  Replace unshared boost::shared_array with std::unique_ptr
  Clarify ownership semantics
  Make NETLIST_OBJECT::GetConnectionType() const
  Avoid static variable in wire merge
  Reserve appropriate space in local vector
  Avoid switch with only default case
  Clean up warnings from exception handlers

 3d-viewer/3d_mesh_model.h                          |  4 +-
 bitmap2component/bitmap2cmp_gui.cpp                | 10 +--
 common/draw_frame.cpp                              |  6 +-
 common/gal/opengl/opengl_gal.cpp                   |  6 +-
 common/geometry/hetriang.cpp                       | 34 +++++-----
 eeschema/class_libentry.cpp                        |  2 +-
 eeschema/class_libentry.h                          |  7 +--
 eeschema/class_library.cpp                         |  4 +-
 eeschema/class_netlist_object.h                    |  4 +-
 eeschema/class_sch_screen.h                        | 32 +++++++---
 eeschema/cross-probing.cpp                         |  2 +-
 eeschema/dialogs/dialog_bom.cpp                    |  2 +-
 eeschema/dialogs/dialog_erc.cpp                    | 47 +++++++++-----
 eeschema/eeschema_config.cpp                       |  6 +-
 eeschema/lib_export.cpp                            |  2 +-
 eeschema/netlist.cpp                               | 16 ++---
 .../netlist_exporters/netlist_exporter_generic.cpp | 73 ----------------------
 .../netlist_exporters/netlist_exporter_generic.h   |  7 ---
 eeschema/project_rescue.cpp                        |  4 +-
 eeschema/sch_base_frame.cpp                        |  5 --
 eeschema/sch_base_frame.h                          |  6 +-
 eeschema/sch_component.h                           |  5 +-
 eeschema/sch_line.cpp                              |  4 +-
 eeschema/sch_screen.cpp                            |  2 +
 eeschema/sch_sheet.cpp                             | 46 +++-----------
 eeschema/sch_sheet.h                               | 11 ++--
 eeschema/schframe.cpp                              |  2 +-
 eeschema/sheet.cpp                                 |  4 +-
 eeschema/symbedit.cpp                              |  2 +-
 gerbview/gerbview_frame.h                          |  5 ++
 include/draw_frame.h                               |  6 +-
 include/gal/cairo/cairo_gal.h                      |  5 +-
 include/gal/opengl/opengl_gal.h                    |  4 +-
 include/gal/opengl/vertex_manager.h                |  6 +-
 include/painter.h                                  |  2 +-
 include/plugins/3dapi/ifsg_node.h                  |  3 -
 include/ttl/halfedge/hetriang.h                    |  9 ++-
 include/wxBasePcbFrame.h                           |  6 +-
 pagelayout_editor/pl_editor_frame.h                |  8 +--
 pcb_calculator/datafile_read_write.cpp             |  2 +-
 pcb_calculator/pcb_calculator.cpp                  | 12 +---
 pcbnew/CMakeLists.txt                              |  2 +
 pcbnew/class_board_connected_item.h                |  2 +-
 pcbnew/class_module.cpp                            |  2 +-
 pcbnew/class_netclass.cpp                          |  6 +-
 pcbnew/class_netclass.h                            |  5 +-
 pcbnew/dialogs/dialog_design_rules.cpp             |  4 +-
 pcbnew/dialogs/wizard_add_fplib.cpp                |  2 +-
 pcbnew/drc_stuff.h                                 |  4 +-
 pcbnew/legacy_plugin.cpp                           |  4 +-
 pcbnew/legacy_plugin.h                             |  4 +-
 pcbnew/moduleframe.cpp                             |  8 +--
 pcbnew/pcb_painter.h                               |  3 +-
 pcbnew/pcb_parser.cpp                              |  4 +-
 pcbnew/ratsnest_data.cpp                           | 13 ++--
 pcbnew/ratsnest_data.h                             |  4 +-
 pcbnew/router/pns_optimizer.h                      |  2 +-
 pcbnew/specctra.h                                  |  5 +-
 pcbnew/tools/edit_points.h                         |  9 +--
 pcbnew/tools/point_editor.cpp                      |  5 +-
 pcbnew/tools/point_editor.h                        |  9 +--
 pcbnew/tools/selection_tool.cpp                    |  2 +-
 utils/idftools/idf_parser.cpp                      |  8 +--
 63 files changed, 218 insertions(+), 312 deletions(-)

-- 
2.1.4


Follow ups