kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #24931
[PATCH 15/16] Avoid switch with only default case
These switch statements only have a single "default" case, so they are unneeded.
---
bitmap2component/bitmap2cmp_gui.cpp | 10 +---------
pcb_calculator/pcb_calculator.cpp | 12 +-----------
2 files changed, 2 insertions(+), 20 deletions(-)
diff --git a/bitmap2component/bitmap2cmp_gui.cpp b/bitmap2component/bitmap2cmp_gui.cpp
index 5caa7a6..99ad647 100644
--- a/bitmap2component/bitmap2cmp_gui.cpp
+++ b/bitmap2component/bitmap2cmp_gui.cpp
@@ -672,15 +672,7 @@ static struct IFACE : public KIFACE_I
wxWindow* CreateWindow( wxWindow* aParent, int aClassId, KIWAY* aKiway, int aCtlBits = 0 )
{
- switch( aClassId )
- {
-
- default:
- {
- KIWAY_PLAYER* frame = new BM2CMP_FRAME( aKiway, aParent );
- return frame;
- }
- }
+ return new BM2CMP_FRAME( aKiway, aParent );
}
/**
diff --git a/pcb_calculator/pcb_calculator.cpp b/pcb_calculator/pcb_calculator.cpp
index 6a9f970..384bc8e 100644
--- a/pcb_calculator/pcb_calculator.cpp
+++ b/pcb_calculator/pcb_calculator.cpp
@@ -61,17 +61,7 @@ static struct IFACE : public KIFACE_I
wxWindow* CreateWindow( wxWindow* aParent, int aClassId, KIWAY* aKiway, int aCtlBits = 0 )
{
- switch( aClassId )
- {
- default:
- {
- PCB_CALCULATOR_FRAME* frame = new PCB_CALCULATOR_FRAME( aKiway, aParent );
- return frame;
- }
- break;
- }
-
- return NULL;
+ return new PCB_CALCULATOR_FRAME( aKiway, aParent );
}
/**
Follow ups
References
-
[PATCH 00/16] Simple patches
From: Simon Richter, 2016-06-07
-
[PATCH 01/16] Fix spelling "propage" -> "propagate"
From: Simon Richter, 2016-06-07
-
[PATCH 02/16] Add missing dependency github_plugin -> pcbcommon
From: Simon Richter, 2016-06-07
-
[PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets
From: Simon Richter, 2016-06-07
-
[PATCH 04/16] Explain how ERC works.
From: Simon Richter, 2016-06-07
-
[PATCH 05/16] Cache netlist item during ERC
From: Simon Richter, 2016-06-07
-
[PATCH 06/16] Check sorting of netlist during ERC
From: Simon Richter, 2016-06-07
-
[PATCH 07/16] Kill unused NETLIST_EXPORTER_GENERIC::writeListOfNets
From: Simon Richter, 2016-06-07
-
[PATCH 08/16] Drop extra copy ctors from IFSG_NODE
From: Simon Richter, 2016-06-07
-
[PATCH 09/16] Replace boost::shared_ptr with std::shared_ptr
From: Simon Richter, 2016-06-07
-
[PATCH 10/16] Replace unshared boost::shared_array with std::unique_ptr
From: Simon Richter, 2016-06-07
-
[PATCH 11/16] Clarify ownership semantics
From: Simon Richter, 2016-06-07
-
[PATCH 12/16] Make NETLIST_OBJECT::GetConnectionType() const
From: Simon Richter, 2016-06-07
-
[PATCH 13/16] Avoid static variable in wire merge
From: Simon Richter, 2016-06-07
-
[PATCH 14/16] Reserve appropriate space in local vector
From: Simon Richter, 2016-06-07