kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 6/9/2016 2:44 AM, jp charras wrote:
> Le 09/06/2016 à 08:31, Cirilo Bernardo a écrit :
>> Thanks Jean-Pierre,
>>
>>  I'll work on the help button and on the display of KISYS3DMOD. In the case
>> of KISYS3DMOD, should I allow editing of the value or just display it?
>>
>> - Cirilo
> 
> I do not have a strong opinion.
> 
> Try to allow editing.
> It is the more difficult case to avoid issues!
> Currently, when you change the KISYS3DMOD value, the new value is not taken in account by the 3D
> viewer: you have to exit Kicad and restart it.

Please only show the value of of KISYS3DMOD.  It can already be edited
using the path configuration dialog.  I just see too many potential
issues if you can edit environment variable in multiple places.  If you
need to edit KISYS3DMOD or any other environment variable, why not just
show the existing path configuration dialog?

Wayne

> 
>>
>>
>> On Thu, Jun 9, 2016 at 3:58 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:
>>
>>> Le 30/05/2016 à 10:56, Cirilo Bernardo a écrit :
>>>> Attached is an updated patch made against r6854.  A patch to fix Bug
>>>> #1585714 prevented the previous patch from applying cleanly.
>>>>
>>>> - Cirilo
>>>>
>>>>
>>>
>>> Hi, Cirilo,
>>>
>>> I committed your patch in rev 6905. Thanks.
>>>
>>> After playing with your 3D path config dialog, I am thinking it needs 2
>>> enhancements:
>>>
>>> - A help button to display info about aliases meaning and usage (with an
>>> example), like the help
>>> button in path configuration dialog
>>> - At least display the KISYS3DMOD env variable value, which is used
>>> (explicitly or implicitly) in 3D
>>> path resolution
>>>
>>> Could you add them?
>>> Thanks.
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>
> 
>