← Back to team overview

kicad-developers team mailing list archive

Re: 3D-Viewer - Request for merge evaluation

 

On 6/20/2016 8:50 AM, Nick Østergaard wrote:
> 2016-06-20 14:45 GMT+02:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>> I had some time over the weekend to look at this and I'm satisfied with
>> it although I'm not 100% sure what it buys us.  The eye candy is nice.
>> The performance not so much but such is the case with povray.  My
>> biggest gripe is that the povray rendering button on the toolbar doesn't
>> give any feedback as to whether or not the povray rendering is enabled.
> 
> The button on the toolbar is not to toggle raytracing vs opengl, it is
> just a "single shot" raytrace button.

Thanks for the clarification.  I assumed it was a toggle button to
select the drawing mode.

> 
>> It would be nice if this was a toggle button rather than having to go
>> into the menu to see which mode is being rendered.  Other than that, the
>> only thing you need to resolve is any outstanding crash/freeze bugs
>> before I would be willing to merge it into the product branch.
>>
>> On 6/17/2016 7:55 AM, Mário Luzeiro wrote:
>>> Thank Wayne! Looking for your feedback...
>>>
>>> I was comparing my branch with current kicad branch and found some modules on my branch that were never tested by me.
>>> Due the use of new structures related with 3d shapes information there are some changes on pcbnew.
>>> They were imported from Cirilo's branch while he was working on 3d plugin refactoring. They are:
>>> export_idf.cpp
>>> export_vrml.cpp
>>> kicad_plugin.cpp
>>> legacy_plugin.cpp
>>>
>>> The changes handle with the new S3D_INFO structure (store 3d shape information of the footprints).
>>> If anyone that is testing my branch also knows how to test this modules I appreciate.
>>> Thanks,
>>> Mario Luzeiro
>>> ________________________________________
>>> From: Wayne Stambaugh [stambaughw@xxxxxxxxx]
>>> Sent: 14 June 2016 19:02
>>> To: Mário Luzeiro; kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Subject: Re: 3D-Viewer - Request for merge evaluation
>>>
>>> Mario,
>>>
>>> I may not have time to look at it until this weekend.  As soon as I've
>>> had a chance to build and run it and look over the code, I'll let you know.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp


References