← Back to team overview

kicad-developers team mailing list archive

Re: 3D-Viewer - Request for merge evaluation

 

Additionally I can't figure out what the bottom left button is for the
preview. It is rendered as two circular arrows on my screen. i can't
see the view changing when I click it.

2016-06-22 23:20 GMT+02:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
> Hi Mario
>
> I have noticed someting new.
>
> When I hit edit on a footprint, then switch to the 3D Settings tab it
> will freeze briefly until the 3D preview is assembled. Ok. Then I
> close the dialog on cancel. Then I open it again on the same footprint
> and it now shows the 3D Settings tab directly instead of the
> Properties tab, but now it is seen that the content in the 3D preview
> is the image on the screen from the Opengal (GAL) canvas that was in
> pcbnew itself. Maybe the 3D preview need to initialize a black canvas
> to avoid this transient artifact?
>
> Nick
>
> 2016-06-19 22:36 GMT+02:00 Nick Østergaard <oe.nick@xxxxxxxxx>:
>> 2016-06-19 20:09 GMT+02:00 Mário Luzeiro <mrluzeiro@xxxxx>:
>>> Hi Nick,
>>>
>>> Thanks for the comments.
>>>
>>>
>>>> It seems that it cannot abort while performing the post processing shader.
>>>
>>> True, but.. What CPU do you have?
>>
>> Intel(R) Core(TM) i5 CPU       M 540  @ 2.53GHz
>>
>> That is a two core cpu with hyperthreading of 4.
>>
>>> It should take just hundreds of ms ... up to <1s depending on many cores you have.
>>>
>>
>> It takes about a second. If I time it manually I get about 1.4 to 1.5
>> seconds, by looking at the status bar. I can even make it three to
>> five seconds. Same board, just zoomed in. It is not a complex board,
>> it just contains a few footprints, a three VRML models and a STEP
>> model.
>>
>>>
>>>> When in opengl mode and you hit the render button, it will show the lowres raytrace.
>>>> I think it might be better to keep showing the last opengl image instead of the lowres raytrace, maybe.
>>>
>>> I implemented that suggestion, check my latest branch updates.
>>>
>>
>> That feels way better.
>>
>>>
>>>> Also, there is a black border when in raytracing mode.
>>>> When I resize the window it will short of change in jumps.
>>>> I assume this is because you have a "discrete" size for the image itself.
>>>> Is this something you plan to change/fix?
>>>
>>> At this moment it is not an easy change.
>>> But with your previous suggestion and some other changes I did (in raytracing mode preview) it may looks more OK.
>>>
>>> The render is optimized in ray packages. One possible solution will be in future to render to a bigger than screen buffer resolution, then draw that buffer on the windows. That will waste some computation but should be OK.
>>>
>>
>> I think that will be a sane solution. I don't mind too much, I just
>> noticed the behaivour.
>>
>>> Anyway... a black frame is something that increase the value price of your picture ;)
>>
>> I think it needs to be a frame of gold leafs. :P
>>
>>>
>>> Mario
>>>
>>> ________________________________________
>>> From: Nick Østergaard [oe.nick@xxxxxxxxx]
>>> Sent: 18 June 2016 13:08
>>> To: Mário Luzeiro
>>> Cc: Cirilo Bernardo; Chris Pavlina; kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Subject: Re: [Kicad-developers] 3D-Viewer - Request for merge evaluation
>>>
>>> Hi Mario,
>>>
>>> I just tried to test this, and I will comment a bit.
>>>
>>> It seems that it cannot abort while performing the post processing shader.
>>>
>>> When in opengl mode and you hit the render button, it will show the lowres raytrace. I think it might be better to keep showing the last opengl image instead of the lowres raytrace, maybe.
>>>
>>> Also, there is a black border when in raytracing mode. When I resize the window it will short of change in jumps. I assume this is because you have a "discrete" size for the image itself. Is this something you plan to change/fix?


Follow ups

References