← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH 03/16] Clarify ERC: we're iterating netlist items, not nets

 

This patch and patches 0005 and 0006 of this patch set do not apply
cleanly.  Please rebase and resubmit them when you get a chance.  FYI,
the coding policy frowns upon mixing camel case and underscores.  I know
there are cases of this in the code but they are most likely left over
from before the coding policy was implemented.  Please rename
lastItem_idx to lastItemIdx or last_item_idx.  The same goes for
nextItem_idx.

Thanks,

Wayne

On 6/7/2016 3:54 PM, Simon Richter wrote:
> 
> This renames the "net", "lastNet" and "nextNet" variables to "item",
> "lastItem" and "nextItem", respectively, because these refer to netlist
> items, not nets.
> ---
>  eeschema/dialogs/dialog_erc.cpp | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
> 


Follow ups

References